Skip to content

Conversation

@kwacky1
Copy link

@kwacky1 kwacky1 commented Jun 5, 2025

Description

Simple update to get the tests to run. Fixes the caching and import statements.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • Other (please describe):

How Has This Been Tested?

I checked out the branch and manually ran the tests and fixed the errors that I encountered until I got the tests to run.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation (if applicable)

Related Issues

Fixes https://github.com/OpenSourceFellows/dashboard_server/issues/88

Copy link
Collaborator

@SAUMILDHANKAR SAUMILDHANKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kwacky1, PR mentions it would fix https://github.com/OpenSourceFellows/dashboard_server/issues/88
and is marked a bug fix as well.
Based on what I know integration with notion isn't complete yet so please share which tests this PR is about. Apologies the review took a bit of time but thanks for your contribution and look forward to making progress.

@kwacky1
Copy link
Author

kwacky1 commented Jan 5, 2026

Hey there @SAUMILDHANKAR I don't have access to the issue any more and don't really remember what the issue was but based on the changes it just fixes a few little things that should get the tests working, but if notion is not required then feel free to close this PR.

@SAUMILDHANKAR
Copy link
Collaborator

@kwacky1 thanks a lot for getting back. Apologies I moved the issue to a private repo since we now have two repos (front and back end). Notion is required so not planning to close this PR. If you want to continue working on this I can bring the issue details in a comment here. Otherwise I will just wait till notion is integrated and then review this PR again to check if tests working fine.

If you want to work on any other issue is this project please let me know as well. Thank you and have a great year 2026 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants