Skip to content

Conversation

@peanutenthusiast
Copy link
Collaborator

@peanutenthusiast peanutenthusiast commented Jun 4, 2025

Description

Adds the ecoinfra-analysis.yml file

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • Other (please describe):

How Has This Been Tested?

Not sure if Applicable?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation (if applicable)

Related Issues

Addresses #44

@peanutenthusiast peanutenthusiast marked this pull request as ready for review June 4, 2025 20:34
@blopez024
Copy link
Collaborator

I'm not too familiar with ecoinfra, so I don't think I'm the best person to review this PR.

Perhaps @CodingLady22, who created issue #44, could take a look?

Since this seems to involve Terraform, maybe @DietBepis1 could also review it?

@peanutenthusiast
Were you able to test this locally? If you're up for going the extra mile, it would be awesome if you could write some documentation in the GitHub Wiki or Discussions. Something that explains:

  • What ecoinfra does
  • How it works
  • How it should be configured and set up in our repo
  • Any known limitations or drawbacks

This would be great practice for a real software job, documentation and design are key responsibilities in professional development work.

@blopez024 blopez024 linked an issue Jun 4, 2025 that may be closed by this pull request
2 tasks
@peanutenthusiast peanutenthusiast requested review from DietBepis1 and removed request for blopez024 June 5, 2025 00:45
@peanutenthusiast
Copy link
Collaborator Author

peanutenthusiast commented Jun 5, 2025

Hi @blopez024 - appreciate your comments.

I can potentially add a quick blurb about this Github Action via the readme:
#44 (comment)

However, per @CodingLady22's response, seems like this isn't required just yet.

Given that this is one of 3 other Github Action related PR's, it would be helpful to know whether the documentation you've requested would be AC for the related issue to close.

It might be better to write up further documentation after further contributions have been pushed to the main branch.

I'll await @DietBepis1's comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Architecture] Github Action: Add Eco-Infra Action

3 participants