tests: fix testfilters line counting and missing header#118
Closed
shreyanshtiwari4 wants to merge 2 commits intoOpenPrinting:masterfrom
Closed
tests: fix testfilters line counting and missing header#118shreyanshtiwari4 wants to merge 2 commits intoOpenPrinting:masterfrom
shreyanshtiwari4 wants to merge 2 commits intoOpenPrinting:masterfrom
Conversation
Fix testfilters.sh to parse and count the test-filter-cases.txt file automatically and in turn removing the need to hardcode the total number of testcases everytime any change is made to test-filter-cases.txt file. Also added the missing <sys/stat.h> include in header of testfilters.c file(which is required for S_IRUSR/S_IWUSR on some platforms).
shreyanshtiwari4
force-pushed
the
tests/testfilters-line-count
branch
from
11614b3 to
48ae8fd
Compare
Contributor
Author
|
Added an optional FilterChain column to test-filter-cases.txt header, and will add a corresponding conditional logic in testfilters harness so that , if people have option to use cfFilterChain() with there own CUPS array created manually, instead of just using cfFilterUniversal(). |
And updated descriptive comments for Job-Id, User, Title and Copies while appending optional FilterChain column.
shreyanshtiwari4
force-pushed
the
tests/testfilters-line-count
branch
from
48ae8fd to
30d5f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix testfilters.sh to parse and count the test-filter-cases.txt file automatically and in turn removing the need to hardcode the total number of testcases everytime any change is made to test-filter-cases.txt file, and if the testcases count was wrong the risk of skipping some testcases silently was there.
Also added the missing <sys/stat.h> include in header of testfilters.c file(which is required for S_IRUSR/S_IWUSR on some platforms).