chore: dedup SubqueriesBase between sql and r2dbc#1627
Closed
Conversation
velo
force-pushed
the
feature/dedup-r2dbc-tests
branch
2 times, most recently
from
f2269eb to
a0d570d
Compare
Extending AbstractHibernateQuery to support simple Common Table Expressions.
velo
force-pushed
the
feature/dedup-r2dbc-tests
branch
from
a0d570d to
533fec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR establishes the foundation for deduplicating tests between the synchronous querydsl-sql and asynchronous querydsl-r2dbc modules.
The previous session's approach created a cyclic dependency and attempted to resolve the lack of a common DML interface by using an unstructured SharedTest helper. This approach proved too fragile to extend properly.
Instead, I wrote a test adaptor script that reads the SQL base tests and translates them structurally to R2DBC, preserving their behavior completely, mapping types, resolving domain generation issues, adding
.block()conversions for async fetches and adjusting class inheritances correctly.This PR serves as a proof-of-concept by deduplicating
SubqueriesBase.java. The Python script can be expanded to automate the deduplication of the rest of the test suite (likeSelectBase,InsertBase, etc.).