-
Notifications
You must be signed in to change notification settings - Fork 31
Add operational process section for update management #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
huss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oykunle Thank you for updating the site update process documentation. I've made a few comments to consider before implementation should proceed.
|
|
||
| This section describes the concrete steps OED maintainers should follow to keep update notifications accurate and consistent. | ||
|
|
||
| ### When a new OED release is published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section headers should have a blank line before/after.
Also, indenting should be with 2 spaces and not tabs for markdown.
|
Hi @huss , thank you for the feedback! I’ve added:
The section headers were also formatted with blank lines as requested. Please let me know if any further adjustments are needed. |
Adds the exact GitHub Pages location for latestVersion.json, a full JSON schema example, and documents how to generate and publish SHA-256 checksums as GitHub release assets.
huss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oykunle Thank you for the updated file. I've resolved previous comments that are done but one remains with additional info. I also made a few more comments to consider.
| #### Step 2: Check Only When an Admin Logs In | ||
|
|
||
| - OED performs this fetch: GET https://oed-project.github.io/latestVersion.json | ||
| - OED performs this fetch: GET https://openenergydashboard.github.io/DesignDocs/update-metadata/latestVersion.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should reference the design docs. Maybe under update-metadata/latestVersion.json?
| Your OED version is no longer supported. Please upgrade soon. | ||
|
|
||
| Additional improvements: | ||
| - Show current version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unclear on how these are provided by the JSON file that is received.
| - Sites can verify downloads without needing new infrastructure | ||
| - Fits GitHub’s security model | ||
|
|
||
| How to generate SHA-256 checksums |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a web search, it seems you can use GitHub actions to automatically generate the checksum for a release. Also, there is a way to add it to the GitHub release as a note. I think these should be figured out and included.
| ### When a new OED release is published | ||
|
|
||
|
|
||
| 1. Update the version metadata file: DesignDocs/docs/update-metadata/latestVersion.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a sample should be linked and/or the actual one in this design doc folder.
This PR adds an "Operational Process for OED Maintainers" section to clarify how the proposed update-notification system would be maintained in practice.
It documents:
This is intended to make the proposal easier to implement and maintain long-term.