python3Packages.click: 8.2.1 -> 8.3.1

[dotlambda]

Diff: pallets/click@8.2.1...8.3.1

Changelog: https://github.com/pallets/click/blob/8.3.1/CHANGES.rst

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

For everyone pinged here without reason: These accidental pings happened for maintainers of packages with broken meta.position, when their package was rebuilt on staging without actually touching the file. These pings are now fixed as of #454648.

[dotlambda]

This seems to break python3Packages.flask:

=========================== short test summary info ============================
FAILED tests/test_cli.py::test_run_cert_path - Failed: DID NOT RAISE <class 'click.exceptions.BadParameter'>
FAILED tests/test_cli.py::test_run_exclude_patterns - click.exceptions.BadParameter: Required when using "--cert".
=================== 2 failed, 486 passed, 2 skipped in 2.19s ===================

See pallets/flask#5836

[fabianhjr]

pallets/click#3109 (comment)

Maybe go for 8.3.0?

Retracting approval due to breakage documented by dotlambda

[dotlambda]

Maybe go for 8.3.0?

That would cause pimutils/todoman#596

[iedame]

Click 8.2.1 broke tests on some packages, reference: pallets/click#2939
Subscribing to check affected packages again after an update is merged.

[dotlambda]

Click 8.2.1 broke tests on some packages, reference: pallets/click#2939

Should we add a patch for that to click?

[iedame]

Click 8.2.1 broke tests on some packages, reference: pallets/click#2939

Should we add a patch for that to click?

It was fixed upstream but if 8.3.x update will take a while, it might help fix some of those failures.

One I checked already excluded Click 8.2.1 in latest update so it is failing due to that restriction.

It will need a patch too if click is not updated.

[dotlambda]

@iedame Feel free to open a PR.

[thunze]

Confirmed that click and all passthru.tests of click now build for both Python 3.12 and 3.13, including flask, but excluding mitmproxy which fails due to an unsatisfied version constraint on the brotli Python package (i.e., unrelated).

[dotlambda]

excluding mitmproxy which fails due to an unsatisfied version constraint on the brotli Python package

fixed in #462265

[dotlambda]

It looks like this broke mkdocs:

======================================================================
FAIL: test_serve_default (tests.cli_tests.CLITests.test_serve_default)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/3lll9y925zz9393sa59h653xik66srjb-python3-3.13.9/lib/python3.13/unittest/mock.py", line 1426, in patched
    return func(*newargs, **newkeywargs)
  File "/build/source/mkdocs/tests/cli_tests.py", line 22, in test_serve_default
    mock_serve.assert_called_once_with(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        dev_addr=None,
        ^^^^^^^^^^^^^^
    ...<8 lines>...
        watch=(),
        ^^^^^^^^^
    )
    ^
  File "/nix/store/3lll9y925zz9393sa59h653xik66srjb-python3-3.13.9/lib/python3.13/unittest/mock.py", line 244, in assert_called_once_with
    return mock.assert_called_once_with(*args, **kwargs)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/nix/store/3lll9y925zz9393sa59h653xik66srjb-python3-3.13.9/lib/python3.13/unittest/mock.py", line 991, in assert_called_once_with
    return self.assert_called_with(*args, **kwargs)
           ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/nix/store/3lll9y925zz9393sa59h653xik66srjb-python3-3.13.9/lib/python3.13/unittest/mock.py", line 979, in assert_called_with
    raise AssertionError(_error_message()) from cause
AssertionError: expected call not found.
Expected: serve(dev_addr=None, open_in_browser=False, livereload=True, build_type=None, config_file=None, strict=None, theme=None, use_directory_urls=None, watch_theme=False, watch=())
  Actual: serve(dev_addr=None, open_in_browser=False, livereload=False, build_type=None, watch_theme=False, watch=(), config_file=None, strict=None, theme=None, use_directory_urls=None)

Maybe mkdocs/mkdocs#4032 is related?
Note that pallets/click#3152 does not fix this.
cc @rkoe