Skip to content

Conversation

@faikp
Copy link
Contributor

@faikp faikp commented Jan 1, 2022

No description provided.

@faikp faikp added the good first issue Good for newcomers label Jan 1, 2022
@faikp faikp requested a review from a team January 1, 2022 10:45
@faikp faikp self-assigned this Jan 1, 2022
</ul>
</nav>
<a href="cart.html"><img src="images/cart.png" width="30px" height="30px"></a>
<img src="images/menu.png" class="menu-icon" onclick="menutoggle()">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add alt attribute

<div class="container">
<div class="row">
<div class="col-2">
<img src="images/image1.png">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add alt in img tags.

position: absolute;
bottom: 0;
left: 50%;
transform: translateX(-50%);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group this properties.

<link href="https://fonts.googleapis.com/css2?family=Poppins:wght@300;500;600;700&display=swap" rel="stylesheet">
<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css">
</head>
<body>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your prettier working? @faikp

</div>
<form id="loginform">
<input type="text" placeholder="Username">
<input type="password" placeholder="Password">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this placeholder attributes do ? @faikp

Comment on lines +72 to +73
<img src="images/play-store.png" alt="">
<img src="images/app-store.png" alt="">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add alt @faikp

<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>cart page - RedStore</title>
<link rel="stylesheet" href="style.css">
<link href="https://fonts.googleapis.com/css2?family=Poppins:wght@300;500;600;700&display=swap" rel="stylesheet">
Copy link
Contributor

@anask601 anask601 Jan 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use import url in css file

    @import url("https://fonts.googleapis.com/css2?family=Poppins:wght@300;500;600;700&display=swap");

<p>$50.00</p>
</div>
</div>
<!-- ------ offer ------ -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this section occupies full width of the viewport (just like header), it will look better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants