-
Notifications
You must be signed in to change notification settings - Fork 78
skip reduction when comparing alloc domains in transpose scheduler #5959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Description
|
| Relevant files | |||
|---|---|---|---|
| Bug fix |
| ||
| Tests |
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 PR contains tests |
| ⚡ Recommended focus areas for review |
Filter Logic Correctness
is_not_reduction and the use of C++20 ranges appears correct, but verify that all reduction domains should indeed be excluded in this context and that the filtering doesn't inadvertently remove domains that should be considered for scheduler selection. |
|
!test |
Greptile OverviewGreptile SummaryFixed transpose scheduler selection logic to correctly handle reduction domains from segmented fusions. The Key changes:
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
|
|
||
| // Filter out reduction domains before comparing | ||
| auto is_not_reduction = [](IterDomain* id) { return !id->isReduction(); }; | ||
| auto ref1_filtered = ref1_loop | std::views::filter(is_not_reduction); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a constant for this.
naoyam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reduction domain is ignored in transpose scheduler, it usually comes from reduction from a segmented fusion, e.g. test
ReductionIterDomainOnInputsIssue1659