Skip to content

Conversation

@alexdenham
Copy link

On the Cervical Creening NHS project we have built a stubbed version of MESH using the fake-mesh which we are looking to upgrade as it's missing some features and is not very stable.

The stubbed MESH needs to be able to dynamically add mailboxes so that each test environment can get its own mailbox and avoid conflicts between environments. I have added an endpoint that supports this feature in mesh-sandbox.

I also added some additional steps to reset mailbox to clear down memory better, as this will be running continuously we want to avoid memory leaks as much as possible.

… steps to reset mailbox to clear down memory
env: str = field(default="local")
build_label: str = field(default="latest")
auth_mode: str = field(default="no_auth")
auth_mode: str = field(default="none")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed when trying to get this to work that I was having issues with authentication even though it looked like no_auth was set. I think no_auth doesn't match anything in the repos and so instead will apply full authentication with this set.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alex ... I think the only question is if auth_mode=none should be the default .. would it be better to default to "full" .. so it will be a concious choice to ignore the authentication, rather than build a client expecting there to be no auth and get a nasty surprise when you try and move this into production?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed that the default being set to full might make sense, I just went with what I thought the intended effect of no_auth was

env: str = field(default="local")
build_label: str = field(default="latest")
auth_mode: str = field(default="no_auth")
auth_mode: str = field(default="none")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alex ... I think the only question is if auth_mode=none should be the default .. would it be better to default to "full" .. so it will be a concious choice to ignore the authentication, rather than build a client expecting there to be no auth and get a nasty surprise when you try and move this into production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants