Open
Conversation
duckduckgrayduck
temporarily deployed
to
squarelet-pi-upgrade-de-kke5l6
duckduckgrayduck
temporarily deployed
to
squarelet-pi-upgrade-de-z8ouak
|
|
||
| # Upgrade pip to a minimum version (26.0 or newer) for security | ||
| # Will need to update this as time goes on. | ||
| RUN python -m pip install --upgrade "pip>=26.0,<27.0" |
Member
There was a problem hiding this comment.
Why are we restricting it to be <27?
Contributor
Author
There was a problem hiding this comment.
26 is the minimum version that is still secure, 27 could introduce breaking changes. We can opt to not restrict it, at the risk of a build failing some time in the future and us having to fix it, or be more proactive and update pip as we run audits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly closes this issue:
https://github.com/MuckRock/issues/issues/35
Read the details in that issue for explanation. Will open a separate issue for upgrading django-allauth. I couldn't find anywhere we were still using pyairtable, so it was removed