-
-
Notifications
You must be signed in to change notification settings - Fork 262
feat(seedless-onboarding): add dataType support for secret data items #7284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huggingbot
wants to merge
28
commits into
main
Choose a base branch
from
feat/data-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,557
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dataType parameter to createToprfKeyAndBackupSeedPhrase and addNewSecretData - Add updateSecretDataItem and batchUpdateSecretDataItems methods - Update fetchAllSecretData to return SecretDataItemWithMetadata[]
lwin-kyaw
requested changes
Dec 2, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
…ckupSeedPhrase method
… PrimarySrp first, then createdAt
…etadata - Add itemId, dataType, createdAt properties to SecretMetadata class - Remove SecretDataItemWithMetadata wrapper type - Update fetchAllSecretData to return SecretMetadata[] directly - Add tests for storage metadata properties
…EUUID sorting TIMEUUID strings are not lexicographically sortable. Replace localeCompare with compareTimeuuid utility that extracts and compares actual timestamps.
huggingbot
commented
Dec 8, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
lwin-kyaw
reviewed
Dec 17, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
lwin-kyaw
reviewed
Jan 6, 2026
lwin-kyaw
reviewed
Jan 6, 2026
lwin-kyaw
reviewed
Jan 6, 2026
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
lwin-kyaw
reviewed
Jan 6, 2026
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
Member
Author
removed |
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
… improve type handling
…dlessOnboardingController
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
do we need to also update |
lwin-kyaw
reviewed
Jan 6, 2026
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
…methods from SeedlessOnboardingController and related tests
…essOnboardingMigrationVersion.V1
Member
Author
fixed here |
lwin-kyaw
previously approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The metadata service now supports a
dataTypecolumn for categorizing secret data (PrimarySrp, ImportedSrp, ImportedPrivateKey). This enables clients to distinguish between different types of backed-up secretsChanges include:
dataTypeparameter to insert operationsupdateSecretDataItemandbatchUpdateSecretDataItemsfor updating existing itemsfetchAllSecretDatato return storage metadata (itemId,dataType) alongside secret dataSecretMetadatato separate local metadata from storage-level metadataReferences
https://consensyssoftware.atlassian.net/browse/SL-350
Checklist
Note
Adds first-class support for
dataType(PrimarySrp, ImportedSrp, ImportedPrivateKey) and migrates legacy secrets to the new format.addNewSecretDatanow requiresdataType: EncAccountDataType(BREAKING);SecretTypeis derived internally. NewrunMigrationsandsetMigrationVersion; persistsmigrationVersionand handles legacy items viaupdateSecretDataItem/batchUpdateSecretDataItems.itemId,dataType,createdAt,storageVersion); newcompare,compareByTimestamp, andmatchesType;fromRawMetadatanow requires storage metadata; removesparseSecretsFromMetadataStore,fromBatch, andsort(BREAKING).fetchAllSecretDatareturns storage metadata, sorts withPrimarySrpfirst, and validates primary SRP type.getTimestampFromTimeuuid,compareTimeuuid,getSecretTypeFromDataType; re-exportsEncAccountDataType.@metamask/utilsto^11.9.0.Written by Cursor Bugbot for commit b78c9af. This will update automatically on new commits. Configure here.