Add an example showing how to update a stratified design at the time analysis#608
Open
LittleBeannie wants to merge 5 commits intomainfrom
Open
Conversation
jdblischak
approved these changes
Feb 5, 2026
Collaborator
jdblischak
left a comment
jdblischak
left a comment
There was a problem hiding this comment.
Overall looks good.
A big picture question (that doesn't have to be addressed for this PR): when is an example long enough that a vignette would be the better option?
| #' # After the delayed effect, the HR is 0.8 for stratum A and 0.5 for stratum B. | ||
| #' fail_rate <- define_fail_rate(stratum = c("A", "A", "B", "B"), | ||
| #' duration = c(3, Inf, 3, Inf), | ||
| #' fail_rate = log(2) / c(9, 9, 9, 15), |
Collaborator
There was a problem hiding this comment.
Does it deserve a comment why the failure rate is different only for stratum B after the delayed effect?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To solve issue #606