fix: harden render against stale window and node inputs#615
fix: harden render against stale window and node inputs#615dekaravanhoc wants to merge 1 commit intoMeanderingProgrammer:mainfrom
Conversation
Add compatibility fallbacks and defensive guards so mixed plugin states or transient windows do not crash scheduled renders, and keep tests runnable on Neovim builds that use --clean instead of --noplugin.
|
I have no idea what problems this PR is attempting to solve. This whole thing smells of AI slop, sorry if it's not and this is just you trying your best. If you want to give back to open source projects evaluate each change critically and understand why each line makes sense or not. Otherwise I just feel less and less inclined to accept external contributions. Below is me feedback for each file: base.luaMy plugin is the only thing that should ever be calling the env.luaJust provides a wrapper view.luaAdds unnecessary checks for the existence of methods in a module. In theory you would need to add these everywhere for it to provide any value and it would make the code awful to work with. Assuming that methods we add to a module will exist is the only sane approach. Adding a validity check on windows might be useful but I'm not sure it is necessary. Creating a reproducible example of when not checking causes a problem should be possible. Definitely not needed in the justfileWhat builds of neovim do not have access to |
Add compatibility fallbacks and defensive guards so mixed plugin states or transient windows do not crash scheduled renders, and keep tests runnable on Neovim builds that use --clean instead of --noplugin.
Hi,
I am using https://github.com/sudo-tee/opencode.nvim and had often several errors with the plugin because of prop access of non existing objects. And seldom on larger md files.
Now everything runs smoothly.
Best regards