Skip to content

improve volume mount handling#57

Closed
jhoogstraat wants to merge 4 commits intoMcrich23:mainfrom
jhoogstraat:feature/volumes
Closed

improve volume mount handling#57
jhoogstraat wants to merge 4 commits intoMcrich23:mainfrom
jhoogstraat:feature/volumes

Conversation

@jhoogstraat
Copy link

@jhoogstraat jhoogstraat commented Feb 25, 2026 •
edited
Loading

I aggregated some changes around volumes and finally added some tests for them.

  • Accept host file mounts
  • Accept relative host paths mounts
  • Use full container mount path for named volumes

@jhoogstraat
Allow for relative volume host paths
d7e6fe4
@jhoogstraat
Fix named volume destination path
31d8010
@jhoogstraat
Remove volume mount directory check
49b974d
@jhoogstraat
Add tests
382a28f 
test(compose-up): remove container runtime content checks

- keep volume tests focused on compose mount mapping behavior

- drop container exec/cat assertions and host content roundtrip checks
@jhoogstraat jhoogstraat closed this by deleting the head repository Mar 8, 2026
@Mcrich23
Copy link
Owner

Mcrich23 commented Mar 8, 2026

@jhoogstraat So sorry I missed this. Is there a reason why you have now closed the PR?

@jhoogstraat
Copy link
Author

jhoogstraat commented Mar 8, 2026

Hi,
actually I deleted my fork as I don't plan to further work on this project in favor of Socktainer (https://github.com/socktainer/socktainer). I don't know if the changes could still be merged, which would be completely fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhoogstraat @Mcrich23