Skip to content

[Update] make CellValue internal#100

Draft
john-dc252 wants to merge 1 commit intoMathNya:masterfrom
john-dc252:feature/cellvalue_internal
Draft

[Update] make CellValue internal#100
john-dc252 wants to merge 1 commit intoMathNya:masterfrom
john-dc252:feature/cellvalue_internal

Conversation

@john-dc252
Copy link
Contributor

Changes:

  • change visibility of CellValue to pub(crate)
  • remove internally unused methods that return CellValue

  ## Changes:

  - change visibility of `CellValue` to `pub(crate)`
  - remove internally unused methods that return `CellValue`
@john-dc252
Copy link
Contributor Author

Since mutators and accessors are already available through Cell, would it not be better to exclude the CellValue type from the public API?

@john-dc252 john-dc252 marked this pull request as draft February 11, 2023 11:21
@MathNya
Copy link
Owner

MathNya commented Feb 17, 2023

john-dc252

Since mutators and accessors are already available through Cell, would it not be better to exclude the CellValue type from the public API?

Sorry for the late reply.
The CellValue API, I think it would be useful to have.
Like when preparing a CellValue and applying it to multiple Cells.
If this is the case, I feel that Cell's set_value_from_string etc. is unnecessary.
As for the system, I want to keep it as simple as possible.
Hmmm, I will consider this a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants