Update the interface for MathOptInterface.jl -- support VectorNonlinearOracle #509
+606
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontoison
commented
Oct 23, 2025
| return MOI.get.(model, MOI.VariablePrimal(attr.result_index), f.variables) | ||
| end | ||
|
|
||
| # function MOI.get( |
Member
Author
There was a problem hiding this comment.
I will need some help for this function.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
===========================================
- Coverage 84.94% 69.05% -15.89%
===========================================
Files 50 14 -36
Lines 4622 1034 -3588
===========================================
- Hits 3926 714 -3212
+ Misses 696 320 -376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amontoison
force-pushed
the
am/moi_oracle
branch
from
de7a665 to
59ea28c
Compare
Member
|
superseded by #548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #508
I updated a little the order of some routines such that the code is almost the same here and in
UnoSolver.jl.It will help to maintain the extension if bugs are found in one of the two Julia packages.
@frapac One the potential issue with
VectorNonlinearOracleis that we don't have support forjprod!,jtprod!orhprod!. Do we always usejtprod!isMadNLP.jl? Do we have a workaround?