Skip to content

Conversation

@jaybraunjr
Copy link
Contributor

No description provided.

@orbeckst
Copy link
Member

@IAlibay do you know why the testing workflow did not run?

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your kit looks excellent and everything seems to be working; your kit is installable via GitHub/source and your tests pass. Your docs look good.

✅ approved as a MDAKit – congratulations 🎉

Recommendation: Make a release on PyPi soon and then update the metadata file.

Comment on lines +53 to +54
# install:
# - pip install packing_defect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your kit is in great shape. It should be easy to make a release on PyPi — I very much encourage you to release it there soon.

@orbeckst orbeckst merged commit 646730e into MDAnalysis:main Dec 17, 2025
5 checks passed
@orbeckst
Copy link
Member

Congratulations on having your MDAKit on the registry!

Sorry that it took so long to sort out the issues and get it reviewed. You did an excellent job in preparing your kit so the review was easy once the tests were running.

Please update your metadata.yml via PR once you have a package on PyPi or want to include links to eg community or CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants