Skip to content

Conversation

@orbeckst
Copy link
Member

@orbeckst orbeckst commented Jan 22, 2026

- fix #153
- replaced MDAnalysis/pypi-deployment action with explicit steps
  (see also MDAnalysis/pypi-deployment#11 for details on issues)
- include full tests of installed packages
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.20%. Comparing base (dd8d17f) to head (d38bbd8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   88.20%   88.20%           
=======================================
  Files           5        5           
  Lines         814      814           
  Branches      107      107           
=======================================
  Hits          718      718           
  Misses         56       56           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- fix #155
- add license files explicitly
- use LGPL 3.0+ identifier
- fix #156
- explicitly list tests and tests.datafiles to be included
@orbeckst
Copy link
Member Author

force pushed the 1.1.0a tag for testing deployment

@orbeckst
Copy link
Member Author

Testing packaged version failed https://github.com/MDAnalysis/GridDataFormats/actions/runs/21233099346/job/61095392408

FAILED tests/test_mrc.py::test_mrcfile_volume_check - AssertionError: Regex pattern did not match.
  Expected regex: 'is not a volumetric density'
  Actual message: 'Wrong/missing data to set up Grid. Use Grid() or Grid(grid=<array>, edges=<list>) or Grid(grid=<array>, origin=(x0, y0, z0), delta=(dx, dy, dz)):\ngrid=/opt/hostedtoolcache/Python/3.14.2/x64/lib/python3.14/site-packages/gridData/tests/datafiles/ispg_0.mrc edges=None origin=None delta=None'

FAILED tests/test_mrc.py::test_mrcfile_volume_force - ValueError: Wrong/missing data to set up Grid. Use Grid() or Grid(grid=<array>, edges=<list>) or Grid(grid=<array>, origin=(x0, y0, z0), delta=(dx, dy, dz)):
grid=/opt/hostedtoolcache/Python/3.14.2/x64/lib/python3.14/site-packages/gridData/tests/datafiles/ispg_0.mrc edges=None origin=None delta=None

MRC files were left out from the distribution in PR #149.
This commit adds them via explicit inclusion pattern in the pyproject.toml file
@orbeckst
Copy link
Member Author

  • TestPyPi upload succeeded
  • local testing pip install -i https://test.pypi.org/simple/ GridDataFormats==1.1.0a0 : all passed

@orbeckst
Copy link
Member Author

If anyone else merges: please do not squash but merge as separate commits. They all do different things and address different issues that came up.

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would specify a version here - otherwise you'll pick up the latest version (which you might not always be ready for).

path: dist/
retention-days: 1

test-install:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would merge this test with the one below - most of the steps are reused, for the most part you're doubling up on wait time just building deps.

path: dist/

- name: Publish to TestPyPI
uses: pypa/gh-action-pypi-publish@v1.12.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 1.13?

path: dist/

- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@v1.12.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: pypa/gh-action-pypi-publish@v1.12.4
uses: pypa/gh-action-pypi-publish@v1.13.0

?


test-deployed-testpypi:
name: Test deployed package (TestPyPI)
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably would be a good idea to have this span both ubuntu and macos latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check inclusion of "datafiles" in distributed package update license identifier automatic deployment PyPi workflow fails

3 participants