[pull] forks/amsterdam from ethereum:forks/amsterdam#119
Merged
pull[bot] merged 1 commit intoLuckQuack:forks/amsterdamfrom Mar 12, 2026
Merged
[pull] forks/amsterdam from ethereum:forks/amsterdam#119pull[bot] merged 1 commit intoLuckQuack:forks/amsterdamfrom
pull[bot] merged 1 commit intoLuckQuack:forks/amsterdamfrom
Conversation
* feat(tests): port stZeroKnowledge ECADD static tests Port pointAddFiller.json and pointAddTruncFiller.json from stZeroKnowledge into the existing test_ecadd.py test suite, adding test vectors that were not already covered: Valid: S1 doubling, S1+S1x2, S1+generator, truncated S1 input. Invalid: valid+not-on-curve, not-on-curve+valid, both not-on-curve. Also fix pre-existing bugs: missing commas in ported_from URL lists (caused implicit string concatenation) and duplicate test ID "Pplus1_2_plus_inf". * fix: use ethereum/tests URLs instead of legacytests in ported_from * fix(tests): add pr= link for #2477 to ecadd ported_from markers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )