Skip to content

Conversation

@ReenigneArcher
Copy link
Member

Description

The NSIS installer now prompts users to confirm installation Virtual Gamepad, providing a link to relevant documentation. The getting started guide adds warnings about potential issues and risks with virtual input devices.

The default option is NO, which is an attempt to further reduce the VirusTotal flags; however this is not ideal for silent installations.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

The NSIS installer now prompts users to confirm installation of the Virtual Gamepad, providing a link to relevant documentation. The getting started guide adds warnings about potential issues and risks with virtual input devices.
@codecov
Copy link

codecov bot commented Dec 1, 2025

Bundle Report

Bundle size has no change ✅

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@4d2391c). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4466   +/-   ##
=========================================
  Coverage          ?   16.40%           
=========================================
  Files             ?       69           
  Lines             ?    13815           
  Branches          ?     6534           
=========================================
  Hits              ?     2267           
  Misses            ?     8514           
  Partials          ?     3034           
Flag Coverage Δ
FreeBSD-14.3-amd64 13.58% <ø> (?)
Homebrew-ubuntu-latest 13.77% <ø> (?)
Linux-AppImage 11.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants