Version bump and bug fixes #299
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses bug fixes in the skill extraction module by correcting a method signature and removing orphaned code. However, it contains a critical issue with the version number change.
- Fixed method signature by adding missing
selfparameter toskill_extraction_promptmethod - Renamed method from
fs_gold_skill_extraction_prompttoskill_extraction_promptfor better clarity - Removed orphaned function call that would have caused a runtime error
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| laiser/skill_extractor_refactored.py | Fixed method signature by adding self parameter and renamed from fs_gold_skill_extraction_prompt to skill_extraction_prompt; removed orphaned code that referenced undefined variable |
| laiser/init.py | Updated version number from "0.3.12" to "0.3.2" (appears to be a version downgrade rather than a bump) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """ | ||
|
|
||
| __version__ = "0.3.12" | ||
| __version__ = "0.3.2" |
There was a problem hiding this comment.
This appears to be a version downgrade from "0.3.12" to "0.3.2". Version 0.3.12 is semantically later than 0.3.2 (12 > 2). If this is meant to be a version bump as indicated in the PR title, consider using "0.3.13" or "0.4.0" instead.
| __version__ = "0.3.2" | |
| __version__ = "0.3.13" |
|
https://colab.research.google.com/drive/17QCfSjHZ1WjRRkm_AmtFZ3tPN2l9WsZS?usp=sharing Tested, working. Observable difference: correlation_coefficient scores looking good |
No description provided.