feat: implement notification service for SSE events#329
Draft
markijbema wants to merge 1 commit intodevfrom
Draft
feat: implement notification service for SSE events#329markijbema wants to merge 1 commit intodevfrom
markijbema wants to merge 1 commit intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements VS Code notifications for agent completion, errors, and permission requests based on user settings.
Changes
New:
src/services/notification-service.tsNotificationServiceclass that subscribes to SSE events viaKiloConnectionService.onEvent()kilo-code.new.notifications.*)session.idle→ shows info notification when agent completes (skips child sessions)session.error→ shows warning notification on session errors (skips child sessions)permission.asked→ shows info notification with "Go to Session" action button (5s cooldown per session)SessionInfofromsession.created/session.updatedevents to resolveparentIDModified:
src/services/cli-backend/types.tssession.errorevent type toSSEEventunionModified:
src/services/cli-backend/connection-service.tssession.errortoresolveEventSessionId()switchModified:
src/extension.tsNotificationServiceand adds it to dispose chainSettings consumed (already defined in package.json)
kilo-code.new.notifications.agent— notify on agent completionkilo-code.new.notifications.permissions— notify on permission requestskilo-code.new.notifications.errors— notify on errorsSound settings (
sounds.*) are not consumed — VS Code has no native sound API.