fix: gate chat textarea autocomplete on enableChatAutocomplete setting#328
Draft
markijbema wants to merge 1 commit intodevfrom
Draft
fix: gate chat textarea autocomplete on enableChatAutocomplete setting#328markijbema wants to merge 1 commit intodevfrom
markijbema wants to merge 1 commit intodevfrom
Conversation
PromptInput.tsx always requested chat completions regardless of the enableChatAutocomplete setting value. Now it listens for the autocompleteSettingsLoaded message, requests the settings on init, and checks chatAutocompleteEnabled() before firing requestAutocomplete().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
enableChatAutocompletesetting inAutocompleteTab.tsxis persisted via VS Code settings, butPromptInput.tsxalways requests chat completions regardless of the setting value. The setting had no effect.Fix
PromptInput.tsxnow listens forautocompleteSettingsLoadedmessages to track theenableChatAutocompletevaluerequestAutocompleteSettingsmessagerequestAutocomplete()on the setting being enabledChanges
webview-ui/src/components/chat/PromptInput.tsx: AddedchatAutocompleteEnabledsignal, settings listener, settings request, and early-return guard