AppBuilder - Tag sessions with app-builder platform identifier#192
Open
AppBuilder - Tag sessions with app-builder platform identifier#192
Conversation
Thread createdOnPlatform through the prepareSession flow so sessions created by App Builder are tagged as 'app-builder' instead of the default 'cloud-agent'. Add 'app-builder' to KNOWN_PLATFORMS for filtering in the CLI sessions list.
| }) | ||
| .optional(), | ||
| upstreamBranch: branchNameSchema.optional(), | ||
| createdOnPlatform: z.string().optional(), |
Contributor
There was a problem hiding this comment.
SUGGESTION: Add a max length to createdOnPlatform in MetadataSchema
PrepareSessionInput caps this at 100 chars, but DO metadata currently accepts an unbounded string. Keeping these aligned helps prevent oversized metadata and makes validation consistent.
Suggested change
| createdOnPlatform: z.string().optional(), | |
| createdOnPlatform: z.string().max(100).optional(), |
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (9 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createdOnPlatformthrough theprepareSessionflow so App Builder sessions are tagged as'app-builder'instead of the hardcoded'cloud-agent'default.'app-builder'toKNOWN_PLATFORMSfor filtering in the CLI sessions list.Changes
createdOnPlatformtoPrepareSessionInputschema (optional string, max 100 chars).createdOnPlatformtoMetadataSchema.createdOnPlatformtoprepare()input type.createdOnPlatformincreateKiloSessionInBackend(), defaulting to'cloud-agent'.createdOnPlatformto both backend session creation and DO preparation.createdOnPlatformfrom metadata into session init options.createdOnPlatformto client-sidePrepareSessionInputtype.createdOnPlatform: 'app-builder'in bothcreateProjectandsendMessageflows.'app-builder'toKNOWN_PLATFORMS.