Deploy - Add 'Made with Kilo' banner for app-builder deployments#105
Open
Deploy - Add 'Made with Kilo' banner for app-builder deployments#105
Conversation
Contributor
Code Review SummaryStatus: 7 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (11 files)
|
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/functions/limitations |
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/app-builder-banner/:worker) backed by KV storage, along with corresponding tRPC endpoints and a UI toggle in the deployment details panel.created_fromcolumn to the deployments table to distinguish app-builder vs regular deployments.Changes
Dispatcher worker (
cloudflare-deploy-infra/dispatcher/):banner/banner-store.ts- KV-backed banner state (enable/disable/check)banner/inject-banner.ts- HTMLRewriter-based script injection with CSP nonce handlingroutes/api.ts- Banner CRUD routesindex.ts- Intercepts HTML responses to inject banner when enabledschemas.ts- Shared schema cleanup (removeddeletePasswordResponseSchema, addedsuccessResponseSchema,getBannerResponseSchema)Backend (
src/):db/schema.ts+ migration - Addscreated_fromcolumn to deploymentslib/user-deployments/dispatcher-client.ts- Banner API methods + zod validation for all responseslib/user-deployments/deployments-service.ts- Auto-enable banner on app-builder deploy, clean up banner on deleterouters/deployments-router.ts+organization-deployments-router.ts-getBannerStatus/setBannertRPC endpointsDemo:
https://rotating-unicorn.d.kiloapps.io