Support for using custom types as tables ids#2154
Open
zhurs wants to merge 1 commit intoJetBrains:mainfrom
Open
Support for using custom types as tables ids#2154zhurs wants to merge 1 commit intoJetBrains:mainfrom
zhurs wants to merge 1 commit intoJetBrains:mainfrom
Conversation
Collaborator
|
Thank you for highlighting the issue, we definitely have lack of tests for custom columns, so problems like this appear. Right now I'm working on the column transforms feature #2143 and it could be also interesting to check if we can use transformed columns as IDs. Anyway, what you mentioned should be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it is suitable to use custom types as table ids (however test example is synthetic).
Right now a lot of operations fail with exception: