Skip to content

Conversation

@c-dilks
Copy link
Member

@c-dilks c-dilks commented Jan 22, 2026

The key parameter of Algorithm::SetOption is manually determined, typically from the Algorithm::GetOption* methods. Instead:

  • generate the key name from the YAML node path's string elements, delimiting elements by "/"
  • throw an exception if a user uses SetOption with an old key name, and print the new name

@c-dilks c-dilks force-pushed the standardize-setoption branch from 6600115 to 52cb87f Compare January 23, 2026 23:36
@c-dilks c-dilks marked this pull request as ready for review January 26, 2026 17:19
@c-dilks c-dilks merged commit 2fa4d91 into main Jan 26, 2026
19 checks passed
@c-dilks c-dilks deleted the standardize-setoption branch January 26, 2026 20:03
@github-project-automation github-project-automation bot moved this from Unsorted to Done in Iguana Jan 26, 2026
@c-dilks c-dilks added the technical PR that is a technical change (i.e., not important to prioritize in release notes) label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical PR that is a technical change (i.e., not important to prioritize in release notes)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants