You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For moller_slic_job.py, what is difference between this job script and existing script slic_job.py?
For signal_pulser_overlay_to_recon_job.py, I suggest to keep this script, and build a new script for no-spacing, like signal_pulser_overlay_to_recon_job_noSpacing.py. Besides, for no-spacing, all contents related to spacing could be removed.
For signal_spaced_to_readout_job.py, it seems that you want no-filtered signal events (num_hodo_hits=0), and overlay with pulser data, and then run job up to readout while no reconstruction. I am not clear why you need such job script without reconstruction.
For single_pulser_recon_job.py, I guess that this script is only for reconstruction with input from readout. If so, input setup should be modified for this script, and all contents related to hpstr should be removed. Besides, if you need a script speficied for recon, then the script could be common for all reconstruction, so the script could be called as recon_job.py or mc_recon_job.py (to be distinguished with data reconstruction).
For recon_job.py, it seems to be reconstruction, format conversion and analysis for data. I suggested to change its name as data_recon_ana_job.py. Besides, the line with datacnv could be removed and job description should be modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing my setup for non-spaced MC production, still WIP.