chore: Remove accelerator_ops catalog pipelines#256
Merged
martyngigg merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
They have all been moved to facility_ops.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request removes numerous extraction, transformation, and configuration files across the data warehouse accelerator, consolidates logging and dataset naming utilities in elt-common, and updates CLI imports in facility_ops_landing to use refactored function signatures. Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
elt-common/src/elt_common/cli.py (1)
74-74:⚠️ Potential issue | 🟡 MinorDocstring does not match implementation: single vs double underscore.
The docstring states the dataset name format is
'{source_domain}__{pipeline_name}'(double underscore), but thedataset_namefunction at lines 120-122 uses a single underscore:f"{source_domain}_{pipeline_name}".Please update the docstring to reflect the actual implementation.
📝 Proposed fix
- The full dataset name becomes '{source_domain}__{pipeline_name}' + The full dataset name becomes '{source_domain}_{pipeline_name}'Also applies to: 120-122
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@elt-common/src/elt_common/cli.py` at line 74, The docstring is inconsistent with the implementation: update the descriptive text that currently states the full dataset name is '{source_domain}__{pipeline_name}' to match the actual format used by the dataset_name function (f"{source_domain}_{pipeline_name}") so the docstring reflects a single underscore; locate the docstring near the CLI module comment and the dataset_name function name to make the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@elt-common/src/elt_common/cli.py`:
- Line 74: The docstring is inconsistent with the implementation: update the
descriptive text that currently states the full dataset name is
'{source_domain}__{pipeline_name}' to match the actual format used by the
dataset_name function (f"{source_domain}_{pipeline_name}") so the docstring
reflects a single underscore; locate the docstring near the CLI module comment
and the dataset_name function name to make the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 20e825ec-41aa-4c98-80e9-33dca09316f2
⛔ Files ignored due to path filters (4)
warehouses/accelerator_ops/extract_load/accelerator_sharepoint/extract_and_load.py.lockis excluded by!**/*.lockwarehouses/accelerator_ops/extract_load/electricity_sharepoint/extract_and_load.py.lockis excluded by!**/*.lockwarehouses/accelerator_ops/extract_load/opralogweb/extract_and_load.py.lockis excluded by!**/*.lockwarehouses/accelerator_ops/extract_load/statusdisplay/extract_and_load.py.lockis excluded by!**/*.lock
📒 Files selected for processing (80)
elt-common/src/elt_common/cli.pyelt-common/src/elt_common/constants.pyelt-common/src/elt_common/logging.pyelt-common/src/elt_common/pipeline.pywarehouses/accelerator_ops/extract_load/accelerator_sharepoint/extract_and_load.pywarehouses/accelerator_ops/extract_load/electricity_sharepoint/.dlt/config.tomlwarehouses/accelerator_ops/extract_load/electricity_sharepoint/extract_and_load.pywarehouses/accelerator_ops/extract_load/opralogweb/.dlt/config.tomlwarehouses/accelerator_ops/extract_load/opralogweb/.gitignorewarehouses/accelerator_ops/extract_load/opralogweb/extract_and_load.pywarehouses/accelerator_ops/extract_load/opralogweb/tests/__init__.pywarehouses/accelerator_ops/extract_load/opralogweb/tests/conftest.pywarehouses/accelerator_ops/extract_load/opralogweb/tests/fake_source/README.mdwarehouses/accelerator_ops/extract_load/opralogweb/tests/fake_source/__init__.pywarehouses/accelerator_ops/extract_load/opralogweb/tests/fake_source/opralogmodel.pywarehouses/accelerator_ops/extract_load/opralogweb/tests/test_extract_and_load.pywarehouses/accelerator_ops/extract_load/statusdisplay/.dlt/config.tomlwarehouses/accelerator_ops/extract_load/statusdisplay/extract_and_load.pywarehouses/accelerator_ops/transform/.gitignorewarehouses/accelerator_ops/transform/.sqlfluffwarehouses/accelerator_ops/transform/.sqlfluffignorewarehouses/accelerator_ops/transform/README.mdwarehouses/accelerator_ops/transform/analyses/.gitkeepwarehouses/accelerator_ops/transform/dbt_project.ymlwarehouses/accelerator_ops/transform/macros/create_equipment_category_key.sqlwarehouses/accelerator_ops/transform/macros/normalize_whitespace.sqlwarehouses/accelerator_ops/transform/macros/parse_utc_timestamp.sqlwarehouses/accelerator_ops/transform/models/operations/cycles.sqlwarehouses/accelerator_ops/transform/models/operations/cycles.ymlwarehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_records.sqlwarehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_records.ymlwarehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_uncategorized_equipment.sqlwarehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_uncategorized_equipment.ymlwarehouses/accelerator_ops/transform/models/operations/power_consumption.sqlwarehouses/accelerator_ops/transform/models/operations/power_consumption.ymlwarehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/_accelerator_sharepoint__sources.ymlwarehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__edr_equipment_mapping.sqlwarehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__edr_equipment_mapping.ymlwarehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__equipment_downtime_data_11_08_24.sqlwarehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__equipment_downtime_data_11_08_24.ymlwarehouses/accelerator_ops/transform/models/staging/electricity_sharepoint/_electricity_sharepoint__sources.ymlwarehouses/accelerator_ops/transform/models/staging/electricity_sharepoint/stg_electricity_sharepoint_rdm_data.sqlwarehouses/accelerator_ops/transform/models/staging/electricity_sharepoint/stg_electricity_sharepoint_rdm_data.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/_opralogweb__sources.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__additional_columns.sqlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__additional_columns.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__chapter_entry.sqlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__chapter_entry.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__entries.sqlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__entries.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbook_chapter.sqlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbook_chapter.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbooks.sqlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbooks.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__more_entry_columns.sqlwarehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__more_entry_columns.ymlwarehouses/accelerator_ops/transform/models/staging/opralogweb/stg_opralogweb__mcr_equipment_downtime.sqlwarehouses/accelerator_ops/transform/models/staging/opralogweb/stg_opralogweb__mcr_equipment_downtime.ymlwarehouses/accelerator_ops/transform/models/staging/statusdisplay/_statusdisplay__sources.ymlwarehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles.sqlwarehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles.ymlwarehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles__phases.sqlwarehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles__phases.ymlwarehouses/accelerator_ops/transform/models/staging/statusdisplay/stg_statusdisplay__cycles.sqlwarehouses/accelerator_ops/transform/models/staging/statusdisplay/stg_statusdisplay__cycles.ymlwarehouses/accelerator_ops/transform/package-lock.ymlwarehouses/accelerator_ops/transform/packages.ymlwarehouses/accelerator_ops/transform/profiles.ymlwarehouses/accelerator_ops/transform/requirements/developer.inwarehouses/accelerator_ops/transform/requirements/developer.txtwarehouses/accelerator_ops/transform/requirements/requirements.inwarehouses/accelerator_ops/transform/requirements/requirements.txtwarehouses/accelerator_ops/transform/seeds/.gitkeepwarehouses/accelerator_ops/transform/snapshots/.gitkeepwarehouses/accelerator_ops/transform/tests/.gitkeepwarehouses/facility_ops_landing/ingest/accelerator/accelerator_sharepoint/accelerator_sharepoint.pywarehouses/facility_ops_landing/ingest/accelerator/electricity_sharepoint/electricity_sharepoint.pywarehouses/facility_ops_landing/ingest/accelerator/opralogweb/opralogweb.pywarehouses/facility_ops_landing/ingest/accelerator/statusdisplay/statusdisplay.pywarehouses/facility_ops_landing/ingest/beamlines/moderator_performance/moderator_performance.py
💤 Files with no reviewable changes (69)
- warehouses/accelerator_ops/transform/models/operations/cycles.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/stg_opralogweb__mcr_equipment_downtime.yml
- warehouses/accelerator_ops/transform/macros/create_equipment_category_key.sql
- warehouses/accelerator_ops/transform/README.md
- warehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__edr_equipment_mapping.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbooks.yml
- warehouses/accelerator_ops/extract_load/statusdisplay/.dlt/config.toml
- warehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__equipment_downtime_data_11_08_24.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__more_entry_columns.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__entries.sql
- elt-common/src/elt_common/constants.py
- warehouses/accelerator_ops/transform/models/operations/power_consumption.sql
- warehouses/accelerator_ops/extract_load/opralogweb/tests/conftest.py
- warehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles__phases.yml
- warehouses/accelerator_ops/transform/.gitignore
- warehouses/accelerator_ops/transform/macros/normalize_whitespace.sql
- warehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_records.yml
- warehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/_accelerator_sharepoint__sources.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__additional_columns.yml
- warehouses/accelerator_ops/transform/requirements/developer.txt
- warehouses/accelerator_ops/transform/.sqlfluffignore
- warehouses/accelerator_ops/extract_load/opralogweb/.dlt/config.toml
- warehouses/accelerator_ops/transform/models/staging/electricity_sharepoint/stg_electricity_sharepoint_rdm_data.sql
- warehouses/accelerator_ops/transform/models/staging/statusdisplay/stg_statusdisplay__cycles.sql
- warehouses/accelerator_ops/transform/models/staging/electricity_sharepoint/stg_electricity_sharepoint_rdm_data.yml
- warehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__equipment_downtime_data_11_08_24.sql
- warehouses/accelerator_ops/transform/models/staging/accelerator_sharepoint/stg_accelerator_sharepoint__edr_equipment_mapping.sql
- warehouses/accelerator_ops/extract_load/electricity_sharepoint/.dlt/config.toml
- warehouses/accelerator_ops/transform/requirements/requirements.in
- warehouses/accelerator_ops/extract_load/electricity_sharepoint/extract_and_load.py
- warehouses/accelerator_ops/transform/models/operations/power_consumption.yml
- warehouses/accelerator_ops/transform/models/staging/electricity_sharepoint/_electricity_sharepoint__sources.yml
- warehouses/accelerator_ops/transform/models/staging/statusdisplay/_statusdisplay__sources.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__more_entry_columns.sql
- warehouses/accelerator_ops/extract_load/opralogweb/tests/fake_source/init.py
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__entries.yml
- warehouses/accelerator_ops/transform/macros/parse_utc_timestamp.sql
- warehouses/accelerator_ops/transform/dbt_project.yml
- warehouses/accelerator_ops/extract_load/opralogweb/tests/fake_source/README.md
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__chapter_entry.yml
- warehouses/accelerator_ops/transform/package-lock.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/_opralogweb__sources.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__chapter_entry.sql
- warehouses/accelerator_ops/transform/.sqlfluff
- warehouses/accelerator_ops/extract_load/opralogweb/extract_and_load.py
- warehouses/accelerator_ops/transform/requirements/requirements.txt
- warehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles.sql
- warehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__additional_columns.sql
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbooks.sql
- warehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_uncategorized_equipment.yml
- warehouses/accelerator_ops/transform/models/operations/cycles.sql
- warehouses/accelerator_ops/transform/models/staging/statusdisplay/stg_statusdisplay__cycles.yml
- warehouses/accelerator_ops/extract_load/accelerator_sharepoint/extract_and_load.py
- elt-common/src/elt_common/pipeline.py
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbook_chapter.yml
- warehouses/accelerator_ops/transform/models/staging/opralogweb/base/base_opralogweb__logbook_chapter.sql
- elt-common/src/elt_common/logging.py
- warehouses/accelerator_ops/transform/models/staging/statusdisplay/base/base_statusdisplay__cycles__phases.sql
- warehouses/accelerator_ops/extract_load/statusdisplay/extract_and_load.py
- warehouses/accelerator_ops/extract_load/opralogweb/.gitignore
- warehouses/accelerator_ops/extract_load/opralogweb/tests/fake_source/opralogmodel.py
- warehouses/accelerator_ops/transform/models/staging/opralogweb/stg_opralogweb__mcr_equipment_downtime.sql
- warehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_uncategorized_equipment.sql
- warehouses/accelerator_ops/transform/models/operations/mcr_equipment_downtime_records.sql
- warehouses/accelerator_ops/transform/packages.yml
- warehouses/accelerator_ops/transform/requirements/developer.in
- warehouses/accelerator_ops/transform/profiles.yml
- warehouses/accelerator_ops/extract_load/opralogweb/tests/test_extract_and_load.py
martyngigg
force-pushed
the
rm-accelerator_ops-pipelines
branch
from
8a8250b to
f32f217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #255 the ELT jobs for accelerator_ops were removed.
This removes the pipeline scripts themselves now they are in facility_ops.
Refs #203
Summary by CodeRabbit
Release Notes