Skip to content

Conversation

@jaredstehler
Copy link
Contributor

Also fixes new findbugs errors:

[ERROR] Medium: The method 'addKeyToken(Scanner$Token)' in class 'ExtendedScanner' hides a method in class 'Scanner'. Declare the respective methods non-static or private to eradicate the problem. [com.hubspot.jinjava.el.ext.ExtendedScanner] At ExtendedScanner.java:[line 63] HSM_HIDING_METHOD
[ERROR] Medium: Suppressing annotation on the method com.hubspot.jinjava.interpret.JinjavaInterpreter.resolveBlockStubs(OutputList, Stack) is unnecessary [com.hubspot.jinjava.interpret.JinjavaInterpreter] At JinjavaInterpreter.java:[lines 534-597] US_USELESS_SUPPRESSION_ON_METHOD
[ERROR] Medium: Suppressing annotation on the method com.hubspot.jinjava.lib.filter.AbstractFilter.filter(Object, JinjavaInterpreter, Object[], Map) is unnecessary [com.hubspot.jinjava.lib.filter.AbstractFilter] At AbstractFilter.java:[lines 83-126] US_USELESS_SUPPRESSION_ON_METHOD
[ERROR] Medium: Shared primitive variable "reconstructing" in one thread may not yield the value of the most recent write from another thread [com.hubspot.jinjava.lib.fn.eager.EagerMacroFunction, com.hubspot.jinjava.lib.fn.eager.EagerMacroFunction] At EagerMacroFunction.java:[line 269]Another occurrence at EagerMacroFunction.java:[line 287] AT_STALE_THREAD_WRITE_OF_PRIMITIVE
[ERROR] Medium: The method 'instance()' in class 'NonRevertingEagerExecutionMode' hides a method in class 'EagerExecutionMode'. Declare the respective methods non-static or private to eradicate the problem. [com.hubspot.jinjava.mode.NonRevertingEagerExecutionMode] At NonRevertingEagerExecutionMode.java:[line 10] HSM_HIDING_METHOD

@jaredstehler
Copy link
Contributor Author

Moving to basepom 63 is now required for future release publishing.

@jaredstehler jaredstehler merged commit 3c3ecc2 into master Jul 24, 2025
3 checks passed
@jaredstehler jaredstehler deleted the js-basepom-63 branch July 24, 2025 14:47
jasmith-hs pushed a commit that referenced this pull request Sep 29, 2025
bump basepom to 63, add required pom metadata fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants