build: simplify headers handling with file sets#892
Open
Tachi107 wants to merge 1 commit intoHowardHinnant:masterfrom
Open
build: simplify headers handling with file sets#892Tachi107 wants to merge 1 commit intoHowardHinnant:masterfrom
Tachi107 wants to merge 1 commit intoHowardHinnant:masterfrom
Conversation
CMake 3.23 introduced a nice way of handling C and C++ header files together with libraries, File Sets: <https://cmake.org/cmake/help/latest/command/target_sources.html#file-sets> Compared to using the PUBLIC_HEADER property, which were originally just thought for Apple Frameworks anyway, they properly handle adding the correct directories to the include paths during builds and in installed exported targets, mark headers as HEADER_FILE_ONLY, and other goodies documented in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 3.23 introduced a nice way of handling C and C++ header files together with libraries, File Sets:
https://cmake.org/cmake/help/latest/command/target_sources.html#file-sets
Compared to using the PUBLIC_HEADER property, which were originally just thought for Apple Frameworks anyway, they properly handle adding the correct directories to the include paths during builds and in installed exported targets, mark headers as HEADER_FILE_ONLY, and other goodies documented in the docs.