-
Notifications
You must be signed in to change notification settings - Fork 5
docs: align Homebrew formula workflow with CLAUDE.md automation #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Address PR review feedback: 1. Prioritize automated workflow - Add 'just release rxiv-maker' as recommended method - Keep manual workflow as alternative for when just is unavailable - Reference homebrew-formulas repository utilities 2. Fix hardcoded version placeholder - Change VERSION=1.18.4 to VERSION=X.Y.Z for clarity 3. Update path references - Use relative path ../homebrew-formulas (consistent with CLAUDE.md) - Remove hardcoded ~/GitHub/homebrew-formulas assumption 4. Add automation context - Document just utility commands (list, check-updates, sha256) - Link to homebrew-formulas repository for full documentation 5. Restore verification command - Add rxiv check-installation to README macOS section - Mark as optional verification step for LaTeX dependencies Resolves conflicts with CLAUDE.md automation strategy while maintaining manual workflow documentation for contributors without just installed. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Pull Request Review✅ Overall AssessmentThis PR successfully addresses the workflow alignment issues identified in PR #279. The changes are well-structured, clear, and properly prioritize the automated workflow while maintaining the manual option for contributors without Strengths1. ✅ Excellent Workflow Prioritization
2. ✅ Fixed Version Placeholder
3. ✅ Consistent Path References
4. ✅ Enhanced Documentation Context
5. ✅ README.md Improvement
Code Quality & Best Practices✅ Documentation Quality
✅ Consistency
✅ User Experience
Potential Considerations💡 Minor Enhancement Opportunities
Security, Performance & Test Coverage✅ Security
✅ Performance
✅ Test Coverage
Alignment with Project Standards✅ CLAUDE.md ComplianceThe changes align perfectly with CLAUDE.md sections:
✅ Following Project Conventions
Recommendations✅ Ready to MergeThis PR is well-executed and ready to merge as-is. The changes are:
Optional Follow-up (Low Priority)If you want to further enhance the documentation in a future PR:
SummaryVerdict: ✅ APPROVED This is a high-quality documentation improvement that:
Great work addressing the automated review feedback! The documentation is now consistent, clear, and properly guides contributors through both automated and manual workflows. Suggested commit merge message: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Aligns contributor and user documentation for maintaining the Homebrew formula with the automated just-based workflow referenced in CLAUDE.md, while keeping a manual fallback path.
Changes:
- Adds an “Automated Workflow (Recommended)” section for Homebrew formula updates using
just release rxiv-maker. - Reworks the manual Homebrew formula update steps (placeholder version, relative paths, clarified edit location).
- Restores an optional
rxiv check-installationverification step in the macOS README section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Adds optional macOS post-install verification command for LaTeX/dependency sanity-check. |
| CONTRIBUTING.md | Restructures Homebrew formula update guide to recommend just automation and clarifies manual update steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rxiv check-installation # Verify LaTeX and dependencies | ||
| ``` | ||
|
|
||
| **Benefits:** Simple one-command installation, automatic dependency management (Python 3.13, LaTeX, git, gh), easy updates |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macOS “Benefits” line hardcodes Python 3.13, but the Linux/WSL section below documents Python 3.11+. This version-specific claim is likely to drift as the Homebrew formula updates; consider wording this as “Python 3.11+” or just “Python” to keep the README consistent and future-proof.
| **Benefits:** Simple one-command installation, automatic dependency management (Python 3.13, LaTeX, git, gh), easy updates | |
| **Benefits:** Simple one-command installation, automatic dependency management (Python 3.11+, LaTeX, git, gh), easy updates |
|
|
||
| ### 1. Get Package Information from PyPI | ||
| ### Automated Workflow (Recommended) | ||
|
|
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both workflows assume a local checkout of homebrew-formulas exists at ../homebrew-formulas relative to the rxiv-maker repo. Add a short prerequisite (e.g., clone location or adjust the path) so the instructions work for contributors whose repo layout differs.
| Prerequisite: ensure you have a local clone of `homebrew-formulas` at `../homebrew-formulas` relative to your `rxiv-maker` checkout, or adjust the `cd` path below to match your setup. |
| VERSION=X.Y.Z # Replace with new version | ||
| curl "https://pypi.org/pypi/rxiv-maker/$VERSION/json" | \ | ||
| jq -r '.urls[] | select(.packagetype=="sdist") | "URL: \(.url)\nSHA256: \(.digests.sha256)"' |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual workflow depends on jq, but the instructions don’t mention installing it. Please document jq as a prerequisite (or provide an alternative that doesn’t require it) so this step is runnable on a fresh machine.
| rxiv --version | ||
| ``` | ||
|
|
||
| **Note:** The automated workflow using `just` is preferred for consistency and efficiency. See the [homebrew-formulas repository](https://github.com/HenriquesLab/homebrew-formulas) for additional utility commands like `just list`, `just check-updates`, and `just sha256` |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a trailing period at the end of this note (and consider wrapping the long line) to match the surrounding documentation style and avoid markdown-lint line-length violations if enforced.
| **Note:** The automated workflow using `just` is preferred for consistency and efficiency. See the [homebrew-formulas repository](https://github.com/HenriquesLab/homebrew-formulas) for additional utility commands like `just list`, `just check-updates`, and `just sha256` | |
| **Note:** The automated workflow using `just` is preferred for consistency and efficiency. See the | |
| [homebrew-formulas repository](https://github.com/HenriquesLab/homebrew-formulas) for additional | |
| utility commands like `just list`, `just check-updates`, and `just sha256`. |
Create reusable templates for Homebrew formula documentation: 1. HOMEBREW_FORMULA_TEMPLATE.md: - Standard template for CONTRIBUTING.md sections - Standard template for CLAUDE.md sections - Customization guide with package name replacements - Examples for rxiv-maker, TaskRepo, folder2md4llms - Consistency checklist 2. HOMEBREW_DOCS_CHECKLIST.md: - Quick review checklist for CONTRIBUTING.md and CLAUDE.md - Common issues detection (hardcoded versions, absolute paths) - Repository-specific checks - Automated review patterns - Reference to related PRs Benefits: - Ensures consistency across HenriquesLab ecosystem - Provides clear guidance for new package additions - Facilitates automated review detection - Documents established patterns from PR #280, #37, #12 Template can be used for future packages and for reviewing existing documentation across the organization. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
…281) Create reusable templates for Homebrew formula documentation: 1. HOMEBREW_FORMULA_TEMPLATE.md: - Standard template for CONTRIBUTING.md sections - Standard template for CLAUDE.md sections - Customization guide with package name replacements - Examples for rxiv-maker, TaskRepo, folder2md4llms - Consistency checklist 2. HOMEBREW_DOCS_CHECKLIST.md: - Quick review checklist for CONTRIBUTING.md and CLAUDE.md - Common issues detection (hardcoded versions, absolute paths) - Repository-specific checks - Automated review patterns - Reference to related PRs Benefits: - Ensures consistency across HenriquesLab ecosystem - Provides clear guidance for new package additions - Facilitates automated review detection - Documents established patterns from PR #280, #37, #12 Template can be used for future packages and for reviewing existing documentation across the organization. Co-authored-by: Claude Sonnet 4.5 <[email protected]>
* docs: add standardized Homebrew documentation template and checklist Create reusable templates for Homebrew formula documentation: 1. HOMEBREW_FORMULA_TEMPLATE.md: - Standard template for CONTRIBUTING.md sections - Standard template for CLAUDE.md sections - Customization guide with package name replacements - Examples for rxiv-maker, TaskRepo, folder2md4llms - Consistency checklist 2. HOMEBREW_DOCS_CHECKLIST.md: - Quick review checklist for CONTRIBUTING.md and CLAUDE.md - Common issues detection (hardcoded versions, absolute paths) - Repository-specific checks - Automated review patterns - Reference to related PRs Benefits: - Ensures consistency across HenriquesLab ecosystem - Provides clear guidance for new package additions - Facilitates automated review detection - Documents established patterns from PR #280, #37, #12 Template can be used for future packages and for reviewing existing documentation across the organization. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * security: remove private repository references from public docs Remove references to private website-rxiv-maker GitHub repository from public documentation, as per CLAUDE.md security guidelines. Changes: 1. CHANGELOG.md: - Replace GitHub repo link with deployed website URL - Remove website-rxiv-maker from ecosystem list 2. docs/ECOSYSTEM.md: - Update mermaid diagram node (website-rxiv-maker → Documentation Website) - Update repository table with deployed website URL - Update release workflow diagram - Update technical stats table All references now point to the public deployed website: https://rxiv-maker.henriqueslab.org Complies with CLAUDE.md line 338: "The website-rxiv-maker repository is **private** - do NOT reference it in public documentation" Security impact: Prevents exposure of private repository structure and internal development processes. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> --------- Co-authored-by: Claude Sonnet 4.5 <[email protected]>
This patch release focuses on documentation improvements and security compliance: Documentation: - Align Homebrew formula workflow with CLAUDE.md automation (#280) - Add standardized Homebrew documentation templates (#281) - Prioritize just-based automation across ecosystem Security: - Remove private repository references from public docs (#282) - Comply with CLAUDE.md security guidelines Affects: CONTRIBUTING.md, README.md, CHANGELOG.md, docs/ECOSYSTEM.md Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This patch release focuses on documentation improvements and security compliance: Documentation: - Align Homebrew formula workflow with CLAUDE.md automation (#280) - Add standardized Homebrew documentation templates (#281) - Prioritize just-based automation across ecosystem Security: - Remove private repository references from public docs (#282) - Comply with CLAUDE.md security guidelines Affects: CONTRIBUTING.md, README.md, CHANGELOG.md, docs/ECOSYSTEM.md Co-authored-by: Claude Sonnet 4.5 <[email protected]>
Summary
This PR addresses the automated review feedback from PR #279, which identified conflicts between the manual Homebrew formula update workflow in CONTRIBUTING.md and the automated
just-based workflow documented in CLAUDE.md.Fixes identified in post-merge review of PR #279:
Changes Made
1. ✅ Prioritize Automated Workflow
just release rxiv-makeras the recommended methodjustinstalled2. ✅ Fix Hardcoded Version Placeholder
VERSION=1.18.4→VERSION=X.Y.Zto avoid confusion3. ✅ Update Path References
~/GitHub/homebrew-formulas→../homebrew-formulas(relative path)4. ✅ Add Automation Context
justutility commands:just list- List all formulasjust check-updates- Check for PyPI updatesjust sha256- Get SHA256 for specific version5. ✅ Restore Verification Command
rxiv check-installationback to README.md macOS sectionTesting
nox -s lint)Related Issues
Addresses automated review feedback from #279 (already merged)
Workflow Alignment
This PR ensures consistency between:
Both workflows (automated and manual) are now documented, with automation clearly marked as recommended.