feat: Retrieve request metadata from the server#86
Open
chimano wants to merge 1 commit intoGusto:masterfrom
Open
feat: Retrieve request metadata from the server#86chimano wants to merge 1 commit intoGusto:masterfrom
chimano wants to merge 1 commit intoGusto:masterfrom
Conversation
* Add Request Metadata * Fix Misc Issues * Start Sending Metadata * Add Method to get metadata * Change Way of Getting Metadata * Change Way of Getting Metadata * Small Refactor * Fixed bugs and failing test cases * Removed unneeded variable in test --------- Co-authored-by: Matt James <mattjames@dropbox.com> Co-authored-by: chimano <chirac@dropbox.com>
Contributor
|
@chimano I'll take a look at this tomorrow! |
Author
|
@shkolnik Do you have some time to review it this week? |
|
👋 Hello! Thank you for all that you've put into creating and maintaining this Gem. If there's any feedback you have for improving this change, we'd love to hear it and move this one forward toward merge. |
|
@shkolnik Could you please? Still actual. |
|
Confirmed this PR works, only nit I had was it returns GRPCWeb::GRPCWebCall instead of GRPC::ActiveCall::SingleReqView which throws development errors with sorbet. But it seems API compatible when I alias them together so all good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the same implementation as grpc-go: https://github.com/grpc/grpc-go/blob/master/Documentation/grpc-metadata.md#sending-and-receiving-metadata---server-side
Clients have the ability to add metadata to requests, but the servers cannot access it. This change allows servers to access the request's metadata from the RPC context. I believe this also resolves #42.