Showing neutral trend when delta is zero. (7.0)#25147
Draft
graylog-internal-actions-access[bot] wants to merge 1 commit into7.0from
Draft
Showing neutral trend when delta is zero. (7.0)#25147graylog-internal-actions-access[bot] wants to merge 1 commit into7.0from
7.0)#25147graylog-internal-actions-access[bot] wants to merge 1 commit into7.0from
Conversation
* Showing neutral trend when delta is zero. * Adding changelog snippet. * Unnecessary data attribute. (cherry picked from commit 891f1ec)
graylog-internal-actions-access
bot
requested review from
kmerz and
linuspahl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #25138 to
7.0.Note: This PR needs a backport to previous version.
Description
Motivation and Context
Prior to this PR, when the delta in the number widget was 0, the trend would be shown as good or bad (depending on trend preference) instead of neutral. This PR is fixing this.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: