Move common Link and LinkContainer into dedicated files.#25146
Open
Move common Link and LinkContainer into dedicated files.#25146
Link and LinkContainer into dedicated files.#25146Conversation
dennisoelkers
approved these changes
Feb 27, 2026
Member
dennisoelkers
left a comment
dennisoelkers
left a comment
There was a problem hiding this comment.
Looks good, added one suggestion inline which you may or may not implement in this PR!
| * All this information will be obtained from the `NodesStore`. | ||
| */ | ||
|
|
||
| class LinkToNode extends React.PureComponent< |
Member
There was a problem hiding this comment.
Should we take the opportunity to turn this into a functional component? It is pretty simple and has no state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
LinkandLinkContainerfromsrc/components/common/router.tsxintosrc/components/common/Link.tsxandsrc/components/common/LinkContainer.tsx.This just makes it a little bit easier to find and import these components. Often when I tried to have a look at the implementation of
LinkContainerI could not find the component directly, because it was part of therouter.tsx.This change includes:
components/common(index.tsx)src/components/common/router.tsxcomponents/common/routertocomponents/commonacross
graylog2-web-interfaceand enterprise web sourcescomponents/common, when importing it fromreact-router-dom./prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/13381
/nocl - refactoring