Do not fetch metrics when browser is hidden#25121
Open
luk-kaminski wants to merge 1 commit intomasterfrom
Open
Do not fetch metrics when browser is hidden#25121luk-kaminski wants to merge 1 commit intomasterfrom
luk-kaminski wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not fetch metrics when browser is hidden.
/nocl
Motivation and Context
Performance improvement.
It seems that in other places in the code polling stops when browser is hidden, metrics is simply an (forgotten?) exception.
How Has This Been Tested?
Tested via side effect - stopped noticing regular permission checks in MongoDbAuthorizationRealm on hidden/minimalized browser/browser tab.
Types of changes
Checklist: