emoticons features added#114
Open
vijaychoudhary24 wants to merge 1 commit intoGravityProject:masterfrom
Open
Conversation
Member
|
Pretty good. I would request to make it message section also, as it will not be a big deal. So that overall smiley will be supported. |
Member
|
Nice! Thank you. It would be a great addition if you could add it to the message section! Then I'll merge it ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Gravity Team,
I have added the emoticons symbol parse feature to gravity, please merge it, if require I will improve it please let me know.
Feature Description : Now writing any post we can add smiley icon like this :) :D :P 🍺 :O and so on.
for now I have just implemented it for feed post section, I will also add it to message section.
Code changes : nothing great, I have just added few line, first I have just added a package called "mattimo:emoticons", and use this package in spacebars.js file to parse the emoticons, I have also mention the comment in this file to my changes
Please merge it so I can enhance my feature further.