fix: rasterize node document leakage #3539
Open
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayush2k02
changed the title
0HyperCube
reviewed
Dec 28, 2025
| let id = row.source_node_id.map(|x| x.0).unwrap_or_else(|| { | ||
| let mut state = DefaultHasher::new(); | ||
| image.data().hash(&mut state); | ||
| // Include document_id to prevent hash collisions between documents |
Contributor
There was a problem hiding this comment.
You can also trivially have collisions within the same document (e.g. by rotating a rectangle with only a thin stroke and a white fill).
I think therefore that it is not viable to hash the images here at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
document_idin the image hash calculation. Now images from different documents never collide even if their pixel data is similar.Screen.Recording.2025-12-28.at.7.46.56.PM.mov
Closes #3533