Improve robustness when panning/tilting/zooming during dragging actions #3526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves aims to improve the robustness when panning/tilting/zooming during dragging actions
Changes
Sometimes during multi-finger actions like tilting or zooming,
PointerUpevent was sent (even though we are still pressing the button), I Added a check for this within theDragStophandler forSelectToolFsmStatewhich ensures the left mouse button is not released before a transformation is committed by ignoringPointerUpevents received while we are still draggingViewport Redraw Stability: Implemented an Overlays message handler for the
Draggingstate. Now, whenever the editor sends a redraw message while dragging, it is prevented from dropping out of Dragging mode.I will be working on related Paper Cut issues within this PR.
https://github.com/user-attachments/assets/30d4d338-9ffb-409e-b3a1-29b749fbbde8
Part of #3500 (drag offset)