Skip to content

Conversation

@nikhil-nari
Copy link

Description

This PR improves aims to improve the robustness when panning/tilting/zooming during dragging actions

Changes

Sometimes during multi-finger actions like tilting or zooming, PointerUp event was sent (even though we are still pressing the button), I Added a check for this within the DragStop handler for SelectToolFsmState which ensures the left mouse button is not released before a transformation is committed by ignoring PointerUp events received while we are still dragging

Viewport Redraw Stability: Implemented an Overlays message handler for the Dragging state. Now, whenever the editor sends a redraw message while dragging, it is prevented from dropping out of Dragging mode.

I will be working on related Paper Cut issues within this PR.
https://github.com/user-attachments/assets/30d4d338-9ffb-409e-b3a1-29b749fbbde8

Part of #3500 (drag offset)

@nikhil-nari nikhil-nari force-pushed the improve-PTZ-drag-actions branch from e73fcbf to 76e9bf8 Compare December 23, 2025 19:59
@nikhil-nari
Copy link
Author

Hi @Keavon I have fixed the first issue of #3500 (drag offset during PTZ), can you please have a look at it when you are available?
I will be working on the remaining issues of #3500 ASAP
Thank you

@0HyperCube
Copy link
Contributor

Hi @nikhil-nari. You did not fix "drag offset during PTZ" like you claim. All you did was disable the overlays whilst dragging (which is not desired). Please test your code. Thanks.

Also please refrain from doing too many things in one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants