Fix Pen tool anchor point overlays disappearing forever after viewing the node graph #3523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
reviewed
Dec 23, 2025
| for (segment_id, bezier, _, _) in vector.segment_iter() { | ||
| if selected_shape_state.is_segment_selected(segment_id) { | ||
| overlay_context.outline_select_bezier(bezier, transform); | ||
| if !selected_shape_state.selected_points().collect::<Vec<_>>().is_empty() { |
Contributor
There was a problem hiding this comment.
There is no need to do collect. Memory allocation is expensive and isn't needed. You can just do selected_shape_state.selected_points().next().is_some().
Contributor
Author
|
@0HyperCube done with changes |
4adex
reviewed
Dec 25, 2025
editor/src/messages/portfolio/document/overlays/utility_functions.rs
Outdated
Show resolved
Hide resolved
4adex
approved these changes
Dec 25, 2025
Member
|
!build |
|
Keavon
changed the title
Keavon
approved these changes
Dec 25, 2025
Member
|
Thanks. Please comment in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Keavon please review this
fixed the issue of pen tool loosing its ability to produce anchor points after open/close of node graph
Screen.Recording.2025-12-23.at.1.58.01.AM.mov
Closes #3505