Desire Lines - update conversion chances#1266
Open
TheThanathor wants to merge 4 commits intoGamemode4Dev:update-26.1from
Open
Desire Lines - update conversion chances#1266TheThanathor wants to merge 4 commits intoGamemode4Dev:update-26.1from
TheThanathor wants to merge 4 commits intoGamemode4Dev:update-26.1from
Conversation
Member
TheThanathor
commented
Feb 22, 2026
TheThanathor
commented
- lowered sprinting penalty
- raised falling penalty
- coarse dirt conversion requires dirt on at least 1 side
- foliage destruction requires coarse dirt conversion
- lowered sprinting penalty - raised falling penalty - coarse dirt conversion requires dirt on at least 1 side - foliage destruction requires coarse dirt conversion
runcows
approved these changes
Feb 28, 2026
Contributor
runcows
left a comment
runcows
left a comment
There was a problem hiding this comment.
Looks good, all i have is a nitpick :P
|
|
||
| # check blocks | ||
| fill ~ ~-0.06 ~ ~ ~-0.06 ~ coarse_dirt replace dirt | ||
| execute positioned ~ ~-0.06 ~ if predicate gm4_desire_lines:can_coarse_dirt run fill ~ ~-0.06 ~ ~ ~-0.06 ~ coarse_dirt replace dirt |
Contributor
There was a problem hiding this comment.
For simplicity, the fill here should no longer be offset down. There's no situation I can think of where it would cause any issues though
Member
There was a problem hiding this comment.
I'm fairly certain the fill having an offset is an oversight by @TheThanathor.
Suggested change
| execute positioned ~ ~-0.06 ~ if predicate gm4_desire_lines:can_coarse_dirt run fill ~ ~-0.06 ~ ~ ~-0.06 ~ coarse_dirt replace dirt | |
| execute positioned ~ ~-0.06 ~ if predicate gm4_desire_lines:can_coarse_dirt run fill ~ ~ ~ ~ ~ ~ coarse_dirt replace dirt |
Comment on lines
+10
to
+14
| # considerations | ||
| # walking speed = 4.317 blocks/s ~ 5 ticks / block | ||
| # sprinting speed = 5.612 blocks/s ~ 4 ticks / block | ||
| # walking ~ 1 - (0.99)^5 = 0.05 ~ 5% chance to convert each block | ||
| # sprinting ~ 1 - (0.98)^4 = 0.07 ~ 7% chance to convert each block |
Contributor
There was a problem hiding this comment.
On merge, we should definitely include this information on the wiki
misode
requested changes
Feb 28, 2026
| "offsetX": 1, | ||
| "predicate": { | ||
| "block": { | ||
| "blocks": "dirt" |
Member
There was a problem hiding this comment.
I think this should also check for coarse dirt?
Bloo-dev
added
the
feature-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.