Add missing return type annotation to json_extension.dump()#195
Merged
craig8 merged 2 commits intopixi-updatefrom Dec 12, 2025
Merged
Add missing return type annotation to json_extension.dump()#195craig8 merged 2 commits intopixi-updatefrom
craig8 merged 2 commits intopixi-updatefrom
Conversation
Merged
Co-authored-by: craig8 <3979063+craig8@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on Pixi update PR
Add missing return type annotation to json_extension.dump()
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dump()function wrapper was missing a return type annotation, causing type checking ambiguity.Changes
-> Nonereturn type annotation todump()ingridappsd/json_extension.pyThe function wraps
json.dump(), which writes to a file object and returnsNone. The annotation now matches the standard library's signature.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.