Skip to content

docs: Clarify allow_client_traits toggle name and behaviour#6782

Open
khvn26 wants to merge 2 commits intomainfrom
fix/clarify-allow-client-traits-toggle
Open

docs: Clarify allow_client_traits toggle name and behaviour#6782
khvn26 wants to merge 2 commits intomainfrom
fix/clarify-allow-client-traits-toggle

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Feb 25, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #6739

The allow_client_traits toggle was labelled "Persist traits when using client-side SDK keys", which implied traits would still be used for evaluation but simply not saved. In reality, when this setting is off, traits from client-side SDKs are completely ignored — they are neither persisted nor used for segment evaluation. This is intentional: it's a security boundary that prevents untrusted clients from sending arbitrary traits to gain access to segments they shouldn't match.

This PR clarifies the toggle name and documentation to match the actual behaviour:

  • Frontend: Renamed toggle to "Allow client-side SDKs to set traits" with a description explaining that traits are fully ignored and why.
  • Security docs: Updated the toggle name reference and expanded the explanation to clarify that traits are not used for evaluation either, not just not persisted.
  • Segments docs: Updated the toggle name reference and wording.

How did you test this code?

Verified the changes visually.

@khvn26 khvn26 requested review from a team as code owners February 25, 2026 14:07
@khvn26 khvn26 requested review from matthewelwell and talissoncosta and removed request for a team February 25, 2026 14:07
@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 25, 2026 2:08pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ignored Ignored Feb 25, 2026 2:08pm
flagsmith-frontend-staging Ignored Ignored Feb 25, 2026 2:08pm

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates and removed docs Documentation updates labels Feb 25, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6782 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6782 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6782 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6782 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6782 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6782 Finished ✅ Results

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and reflects the behaviour I expected from the attribute. We should evaluate the situation and approach for ensuring the logic in the Edge API matches this before merging this though I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation updates front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants