docs: Clarify allow_client_traits toggle name and behaviour#6782
Open
docs: Clarify allow_client_traits toggle name and behaviour#6782
allow_client_traits toggle name and behaviour#6782Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
Docker builds report
|
Contributor
matthewelwell
left a comment
There was a problem hiding this comment.
This looks good to me, and reflects the behaviour I expected from the attribute. We should evaluate the situation and approach for ensuring the logic in the Edge API matches this before merging this though I think?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #6739
The
allow_client_traitstoggle was labelled "Persist traits when using client-side SDK keys", which implied traits would still be used for evaluation but simply not saved. In reality, when this setting is off, traits from client-side SDKs are completely ignored — they are neither persisted nor used for segment evaluation. This is intentional: it's a security boundary that prevents untrusted clients from sending arbitrary traits to gain access to segments they shouldn't match.This PR clarifies the toggle name and documentation to match the actual behaviour:
How did you test this code?
Verified the changes visually.