Conversation
mscroggs
reviewed
Apr 25, 2025
Comment on lines
+27
to
+30
| bool trimmed, | ||
| bool tensor, | ||
| bool tiniesttensor, | ||
| bool rotated2D |
Member
There was a problem hiding this comment.
I'd strongly favour using an enum here rather than a long list of bools. Would it be helpful in the short term to add a Python utility function to create elements in this way? That could be added very quickly if so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to make a generic conformal DeRham element here.
Element: Scope: line, triangle, quadrilateral, tetrahedron, pyramid, prism, hexahedron
Full spaces (P) or trimmed spaces (P-)
Serendipity or tensor product
Tensor product: Tiniest or Full
2D: Grad Curl or Curl Div
-1 Forms: "Real"
0: Forms: scalar fields
1: Vector fields
..
Following and extending Cockburn & Fu (compatible, admissible)