Change 3 prop normal textures from size 518x518 to 512x512 #6982
Change 3 prop normal textures from size 518x518 to 512x512 #6982TrafficConeOfSchooling wants to merge 2 commits intoFAForever:developfrom
Conversation
This will allow the FAF map editor to load props from the ancient-earth section. BC3 texture compression requires a multiple of 4 (in texture size) on every prop related texture for the map editor to load any props from that section.
WalkthroughA changelog entry documenting the resizing of 3 prop normal textures from 518x518 to 512x512 pixels for BC3 texture compression compatibility and FAF map editor compatibility. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is a great find 👍 , the game is also unable to process non-power-of-two textures in some area's of the game, such as terrain stratum textures. It rescales the texture internally to the next power-of-two as it tries to load the texture. |
Description of the proposed changes
I have resized 3 of the normal textures for the ancient earth props to 512 x 512:

eg_bush01_normalsTS.dds
eg_bush02_normalsTS.dds
eg_bush03_normalsTS.dds
These textures were originally at size 518 x 518 which is incompatible with BC3 texture compression.
Hence this error message when the map editor loads the ancient-earth props section.
Testing done on the proposed changes
I took the entire ancient-earth prop folder out of the game files and pasted it into a test map's props folder.
Loading the map folder's props still resulted in the error.
Replacing the 518 x 518 textures with 512 x 512 versions allowed every prop in the map folder to be loaded and used properly.
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.