Chore/SOF-6990-1: update ModelFactory and MethodFactory#30
Open
azech-hqs wants to merge 21 commits intochore/SOF-6990from
Open
Chore/SOF-6990-1: update ModelFactory and MethodFactory#30azech-hqs wants to merge 21 commits intochore/SOF-6990from
azech-hqs wants to merge 21 commits intochore/SOF-6990from
Conversation
Replacing the import of the full underscore package with a scoped import of sortBy from lodash.
Moving the sort/filter functionality from the web-app to mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR concerns a refactoring effort regarding the method data.
Method data for the Pseudopotential has the following dependencies:
The goal of this effort is to include the dependencies in
ModelFactoryandMethodFactoryso that we avoid creating method instances that have no method data.