Conversation
While not being an original Electron event, this one includes the bounds values, saving the additional roundtrip for calling GetBoundsAsync
Relax Migration check for package.json in root
Double-up timeout for electron-builder and other fixes
BrowserWindow: Add OnBoundsChanged event
…a return type of Task<object>.
feat: submit new events for ipcMain
SocketIoFacade: Improve disposal, avoid exception on tear-down
Fix global.json link in solution, add missing json file
This reverts commit 497e6aa.
Add Documentation for Preload Script
pr-comment: Run #47
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
|
Wait a moment - my publish builds are suddenly failing. This could have a thousand reason - but: When I'm building the same commit on AzDo which was building successfully two weeks ago, it's failing now. I suspect some npm dependency. The error is basically that the app code doesn't get copied into Just reproduced with Electron.NET (linux-x64) as well (you don't see an error here - just the files don't get copied anymore) |
This is something that completely breaks Electron.NET as it seems!When you try to reproduce, can you backup any pre-existing Like |
|
This is so sick.... While investigating further with the Electron.NET solution and after I have successfully reproduced the issue with both, Linux and Windows publishing. using ElectronNET.WebApp. Later I tried with the console app and unexpectedly it was working there. It was very confusing, because that's the model which my own (also failing) app is using as well. After many theories and more testing, I tried with ElectronNET.WebApp again - and damn: it can't be true - it was working as well.... We all know these kinds of situation and when somebody tells a story like above, it's a clear case: User Error! And I would have been inclined to assume that I must have done something stupid accidentally - but there's one little caveat: The DevOps build. Two weeks ago, it ran successfully I have no explanation for this... of course: always the same commit on AzDo and the pipeline definition wasn't touched) |
|
It was caused by multiple updates to the minimatch library: https://www.npmjs.com/package/minimatch?activeTab=versions
(there's a "dependabot" PR for this, but already outdated) |
|
Ok so do we need to do something (pin minimatch resolution to a certain version?) or is this already contained / fixed with their latest release? |
|
Yea, that's a good question - surely worth to stop thinking about how to catch up the lost time - for a moment. I'm not deeply familiar with npm, so I don't have an immediate answer to this, but let's look at the facts first:
Now, what I'm wondering about is this: minimatch has been updated 3 times in the past 24h. How does it even happen that npm installs the newest version each time? I mean, nuget doesn't do that. It chooses the highest required min version for each library, but it never uses a newer version when there's no forcing requirement. |
It only installs the most recent matching version. The matching part is governed by semver ranges, which are specified in the The semver ranges are always respected - unless you specify Some package managers such as pnpm introduced rules to avoid most recent releases (e.g., by setting a minimum time - this way circumventing potential issues with freshly published packages). |
|
Hmm - sounds like there's not much we can do then..? |
|
I'd say so. |
|
Then we're good to go. 🚀 |

We did not have a full release for a while - I think the 0.4.1 (which is more like a 0.5.0; open to change the version here) is ready.
Let's move forward?