feat(color): key shortcuts and quick menu favorites can be set to run stand alone Lua tools

[philmoz]

Allow key shortcuts and quick menu favorites to be set to Lua stand alone scripts.

Todo:

• Companion support - read / write radio.yaml
• Companion support - key shortcuts and favorites editing

[philmoz]

Added filter buttons to the shortcut / favorite picker as the menu is getting long.

[philmoz]

@elecpower - I've done the yaml read/write changes for this; but I could use your expertise for the shortcut and favorite editing.

I'm thinking that if the shortcut/favorite is set to QM_APP then show a file selector next to it with the Lua script tool name (like what is done for Lua Script SF/GF editing).

It's further complicated because the Lua script name may not be the file name - it could be the name embedded in the script file (see radio/src/gui/colorlcd/radio/radio_tools.cpp loadLuaTools() function).

[elecpower]

And guess what happens when std::string is added to a struct (again!)? Clue the simulation poops its pants during to initialisation in GeneralSettings copy operator. Found with GX12 in Linux.

[philmoz]

And guess what happens when std::string is added to a struct (again!)? Clue the simulation poops its pants during to initialisation in GeneralSettings copy operator. Found with GX12 in Linux.

Replaceswith char pointers and dynamic allocation.

[elecpower]

@philmoz I've started working on this

[philmoz]

@philmoz I've started working on this

Looks good. I made one change to use the folder name as the default for folder based tools.

[elecpower]

I know yes to this question creates more work for us but should the lua tools dropdowns be mutually exclusive?

[philmoz]

I know yes to this question creates more work for us but should the lua tools dropdowns be mutually exclusive?

Not sure what you mean?

[elecpower]

Not sure what you mean?

What is the likelihood the same lua script would need to be assigned to multiple favourites or shortcuts?

Mutually exclusive within each category.

[philmoz]

What is the likelihood the same lua script would need to be assigned to multiple favourites or shortcuts?

Mutually exclusive within each category.

Probably overkill.

[elecpower]

Your feature. Just thought I would ask.

[pfeerick]

For the favourites/shortcuts it's pretty harmless also... so what if you set them all to MPM Config or whatever!?

[elecpower]

For the favourites/shortcuts it's pretty harmless also... so what if you set them all to MPM Config or whatever!?

If you set them all the same maybe you should seek medical advice and not operate flying objects or heavy machinery.

[pfeerick]

This really does look and work great. Two minor niggles, and one somewhat major issue...

Configuring the favourites thus (on handset):

... resulted in the mangled titles for the two Lua Apps...

on T15, with the PR firmware. The titles are clearly fine though

and it is fine when loaded on Companion simulator

Companion side seems fine and looks good - read and write cycle was ok:

The minor niggles:

• simply that if you have a favourite set to "NONE", it is effectively ignored. i.e. you can't use it to add a gap to seperate icons. Not sure if that is a good or bad thing... just wondering if it will confuse. I initially set slot 3 to NONE thinking I would get a gap between the apps and the "settings". 🤷
• if it is possible, it would be nice if when editing a favourite, it at least jumps back the same filter group the current entry is in (if not even highlighting the selected line also)...

On a unrelated note... the ability to remap the keys is a godsend... especially when you so are used to the RM layout and the Jumper one keeps tripping you up... just move that TELE key and made it MDL (i.e. on T15)! 🤣 ❤️

[philmoz]

Fixed the name issue on radio hardware.

When editing an existing favorite / key shortcut it should select the existing value in the popup list.
However I had previously implemented filtering on the list to prevent duplicate selections; but this then prevented the list showing the current value. It also broke (badly) when apps are selected so I have removed the filtering for now.

Gaps in the favorites list might be tricky.

[pfeerick]

Gaps in the favorites list might be tricky.

That is more just a "if possible"... it is certainly not a blocker. I was initially thinking it could simply add "blank" icons that would probably look just as odd.

Yes, that seems to be working just fine now - and I see what you mean... didn't even notice it was selecting the current entry for the apps but not the settings.

so I have removed the filtering for now.

So you want to re-add it later? Companion currently still does this, but unless you change the value it will preserve duplicates from the radio, so won't need changing to match if this is the case.

[philmoz]

So you want to re-add it later? Companion currently still does this, but unless you change the value it will preserve duplicates from the radio, so won't need changing to match if this is the case.

Filtering fixed to work with both menu items and apps.
For the currently selected favorite or key shortcut the selected value is not excluded so it is automatically highlighted in the popup menu.

[3DRacer]

Excellent work. Is work already underway on translating the quick menu? In my case, German would be preferable.

[pfeerick]

If there isn't an open PR, likely not. If German is what you want, you can look over these two that were opened 5-8 hours ago and give feedback.

• fix(cpn): typos and punctuation in German translations #7122
• chore: Update german radio translations #7123