Skip to content

chore: add .json extension to the informaten.com.a file#702

Open
kerolasa wants to merge 1 commit intomasterfrom
informaten-fix
Open

chore: add .json extension to the informaten.com.a file#702
kerolasa wants to merge 1 commit intomasterfrom
informaten-fix

Conversation

@kerolasa
Copy link
Collaborator

@kerolasa kerolasa commented Jan 7, 2026

The file extension was probably forgot by accident.

Addresses: c346f5f
CC: @Luxaaa

@kerolasa kerolasa self-assigned this Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Linter OK:

Linter result for informaten.com.a.json

@pawel-kow pawel-kow self-requested a review January 12, 2026 11:09
pawel-kow
pawel-kow previously approved these changes Jan 12, 2026
Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawel-kow
Copy link
Member

@Luxaaa there is a linter warning on 404 for logo

@Luxaaa
Copy link
Contributor

Luxaaa commented Jan 12, 2026

@Luxaaa there is a linter warning on 404 for logo

We restructured our website project.
The new URL to our logo is: https://informaten.com/logo_dark.png

@pawel-kow
Copy link
Member

@Luxaaa do you need this template serviceId=a at all, or shall we remove this file?

kerolasa added a commit that referenced this pull request Jan 14, 2026
The file extension was probably forgot by accident.

<review> Update logo url, see reference.

Addresses: c346f5f
Reference: #702 (comment)
Signed-off-by: Sami Kerola <[email protected]>
@kerolasa
Copy link
Collaborator Author

While waiting @Luxaaa to answer if this template is even needed I updated the pull request in commit 6508df1 with a fix to logo URL including a version increment.

The file extension was probably forgot by accident.

<review> Update logo url, see reference.

Addresses: c346f5f
Reference: #702 (comment)
Signed-off-by: Sami Kerola <[email protected]>
kerolasa added a commit that referenced this pull request Feb 2, 2026
The file extension was probably forgot by accident.

<review> Update logo url, see reference.

Addresses: c346f5f
Reference: #702 (comment)
Signed-off-by: Sami Kerola <[email protected]>
@kerolasa
Copy link
Collaborator Author

kerolasa commented Feb 3, 2026

@Luxaaa since you have not given any feedback about this change I will go ahead and ask @pawel-kow to merge it. In case you disagree please send a revert, deletion, or such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants