Update smtpkit.com.domain-auth.json#691
Update smtpkit.com.domain-auth.json#691xindex2 wants to merge 5 commits intoDomain-Connect:masterfrom
Conversation
|
Linter OK: |
xindex2
left a comment
There was a problem hiding this comment.
Fixed! Changed the SPF record from bare TXT type to SPFM type with spfRules
Bumped version from 1 to 2
add Smtpkit : MX & SPF records
pawel-kow
left a comment
There was a problem hiding this comment.
2 issues in the template.
Please also fill in the PR description properly
smtpkit.com.domain-auth.json
Outdated
| "ttl": 3600, | ||
| "txtConflictMatchingMode": "All", | ||
| "essential": "OnApply" | ||
| "txtConflictMatchingMode": "None", |
There was a problem hiding this comment.
Mode = None and setting a prefix does not seem to make any sense
There was a problem hiding this comment.
Fixed - changed back to txtConflictMatchingMode: All and removed the prefix
smtpkit.com.domain-auth.json
Outdated
| "version": 2, | ||
| "logoUrl": "https://smtpkit.com/og-image.png", | ||
| "description": "Configure SPF, DKIM, DMARC, and MX records for SMTPKit email sending service", | ||
| "variableDescription": "SMTPKit will provide these values during domain setup", |
There was a problem hiding this comment.
This field shall give an idea what the variables are about (as in the previous version). Why changed now?
There was a problem hiding this comment.
Fixed - restored detailed variable descriptions
Address review feedback - fix variableDescription and txtConflictMatchingMode
xindex2
left a comment
There was a problem hiding this comment.
Addressed all review feedback:
- Fixed
variableDescriptionwith detailed variable explanations - Changed
txtConflictMatchingModeback to "All" - Removed
hostRequiredandmultiInstance(defaults to false)
smtpkit.com.domain-auth.json
Outdated
| "ttl": 3600, | ||
| "txtConflictMatchingMode": "All", | ||
| "essential": "OnApply" | ||
| "txtConflictMatchingMode": "None", |
There was a problem hiding this comment.
Fixed - changed back to txtConflictMatchingMode: All and removed the prefix
smtpkit.com.domain-auth.json
Outdated
| "version": 2, | ||
| "logoUrl": "https://smtpkit.com/og-image.png", | ||
| "description": "Configure SPF, DKIM, DMARC, and MX records for SMTPKit email sending service", | ||
| "variableDescription": "SMTPKit will provide these values during domain setup", |
There was a problem hiding this comment.
Fixed - restored detailed variable descriptions
|
PR template is still not filled in properly. |
|
Closing this PR in favor of #717 which includes the corrected template (ttl/priority as strings per spec) and a proper PR description. Sorry for the confusion! |
Description
<-- short description of the template(s) and/or reason for update -->
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverExample variable values
<-- to make review process easier please provide example set of variable values for this template -->
<-- Example: -->
<-- Or provide the whole
testDataobject from the Online Editor after testing and using "Add as test" button -->