Skip to content

Update smtpkit.com.domain-auth.json#691

Closed
xindex2 wants to merge 5 commits intoDomain-Connect:masterfrom
xindex2:patch-2
Closed

Update smtpkit.com.domain-auth.json#691
xindex2 wants to merge 5 commits intoDomain-Connect:masterfrom
xindex2:patch-2

Conversation

@xindex2
Copy link

@xindex2 xindex2 commented Dec 26, 2025

Description

<-- short description of the template(s) and/or reason for update -->

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->

<-- Example: -->

var1: aaa
var2: foo.com

<-- Or provide the whole testData object from the Online Editor after testing and using "Add as test" button -->

"testData": {
    "testset": {
      "variables": {
        "domain": "example.com",
        "host": "foo",
        "example": "bar"
      },
      "results": [
        {
          "type": "TXT",
          "name": "foo",
          "ttl": 86400,
          "data": "\"bar\""
        }
      ]
    }
  }

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

Linter OK:

Linter result for smtpkit.com.domain-auth.json

Copy link
Author

@xindex2 xindex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Changed the SPF record from bare TXT type to SPFM type with spfRules

Copy link
Author

@xindex2 xindex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped version from 1 to 2

Copy link
Author

@xindex2 xindex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating SPF & MX

@kerolasa kerolasa self-requested a review January 5, 2026 09:53
kerolasa
kerolasa previously approved these changes Jan 5, 2026
Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues in the template.

Please also fill in the PR description properly

"ttl": 3600,
"txtConflictMatchingMode": "All",
"essential": "OnApply"
"txtConflictMatchingMode": "None",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mode = None and setting a prefix does not seem to make any sense

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - changed back to txtConflictMatchingMode: All and removed the prefix

"version": 2,
"logoUrl": "https://smtpkit.com/og-image.png",
"description": "Configure SPF, DKIM, DMARC, and MX records for SMTPKit email sending service",
"variableDescription": "SMTPKit will provide these values during domain setup",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field shall give an idea what the variables are about (as in the previous version). Why changed now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - restored detailed variable descriptions

Address review feedback - fix variableDescription and txtConflictMatchingMode
Copy link
Author

@xindex2 xindex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all review feedback:

  • Fixed variableDescription with detailed variable explanations
  • Changed txtConflictMatchingMode back to "All"
  • Removed hostRequired and multiInstance (defaults to false)

"ttl": 3600,
"txtConflictMatchingMode": "All",
"essential": "OnApply"
"txtConflictMatchingMode": "None",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - changed back to txtConflictMatchingMode: All and removed the prefix

"version": 2,
"logoUrl": "https://smtpkit.com/og-image.png",
"description": "Configure SPF, DKIM, DMARC, and MX records for SMTPKit email sending service",
"variableDescription": "SMTPKit will provide these values during domain setup",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - restored detailed variable descriptions

@pawel-kow
Copy link
Member

PR template is still not filled in properly.

@xindex2 xindex2 marked this pull request as draft January 15, 2026 15:58
@xindex2
Copy link
Author

xindex2 commented Jan 15, 2026

Closing this PR in favor of #717 which includes the corrected template (ttl/priority as strings per spec) and a proper PR description. Sorry for the confusion!

@xindex2 xindex2 closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants